Closed (fixed)
Project:
Rules
Version:
8.x-3.x-dev
Component:
Rules Core
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
17 Jan 2015 at 16:30 UTC
Updated:
1 May 2015 at 15:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dasjoComment #2
dasjoComment #3
dasjocurrently wip by dermario https://github.com/scuts/rules/commits/admin_ui
Comment #4
dermarioI did some progress here.
https://github.com/scuts/rules/commits/admin_ui
The following features are implemented now:
This is a very basic implementation. In fact its my first try to work with d8 - entities. As fubhy mentioned in IRC he wanted to create a common ui - branch.
Comment #5
dasjoAs discussed with fago, for this patch we should
- add tabs "Reaction Rules", "Rules components"
- Reaction Rules don't need to be implemented yet (can be greyed out/disabled), as we don't have events
- make sure that paths make sense. i would suggest /rules to list the reaction rules but as we don't implement them yet, we could display /rules/components by default
- add validation, currently adding the same Rules component just fails with an exception
- make sure that breadcrumbs are properly in place
- after adding a component, currently you remain on the add dialog. we should return to the components list instead.
Comment #6
dasjoComment #7
ndf commentedGonna work on this one this afternoon.
Comment #8
ndf commentedTalked with klausi and dasjo. Baseline with routers and stubs for rules-reactions are there and pushed.
Couple of things todo before pull-request:
- Define access permissions
- Find a way to supplement MENU_DEFAULT_LOCAL_TASK
This should be done tomorrow.
After that we probably want to separate the admin interface to a 'rules_ui' sub-module.
Comment #9
dasjoComment #10
ndf commentedBranch on github: https://github.com/nielsdefeyter/rules/tree/admin-ui-2409239
Comment #11
ndf commentedRules UI (rules_ui) : 'Administration interface for Rules.' is now a submodule in Rules.
Comment #12
dasjoComment #13
ndf commentedPR: https://github.com/fago/rules/pull/163
has:
- permissions
- overview page so crumbs, tabs are handled well. This page uses systemAdminMenuBlockPage and renders all menu-items one level deeper
- crud for components (was my starting-point, thank scuts)
- stub for settings page
Permissions are implemented in Rules
All other things are implemented in submodule Rules UI
Comment #14
dasjoCool stuff! I have tested it a bit and works really nice. Tabs & breadcrumbs make sense.
These component edit form related tasks haven't been addressed. Let's create a follow-up branch for them.
- add validation, currently adding the same Rules component just fails with an exception
- after adding a component, currently you remain on the add dialog. we should return to the components list instead.
Leaving it on needs review for code review.
Comment #15
fagoThanks - that's already a great start! Reviewed it and mostly commented on output strings - please work them in.
Comment #16
ndf commentedThanks for reviewing. I'll follow up this afternoon.
Comment #17
ndf commentedThanks for reviewing. I'll follow up this afternoon.
Comment #18
ndf commentedPR https://github.com/fago/rules/pull/163
Fixed fago's comments, except
Don't know howto do this.
Klausi commented on protected $tag (in class RulesComponent line ~70)
Prefer to move to follow up ticket.
Comment #19
fagoSounds good. Let's create an ticket for it then and link in the code. Also the code should add an @todo.
Comment #21
fagoThanks, merged live during drupal dev days d8rules session.!