Drupal 7 contained many rules_log() calls from the rules plugins / rules expression classes, which were responsible for keeping the rules debug log and showing it in case of evaluation errors.
In Drupal 8, we want to do so similar but use a logger service instead of the function. As a first step, we can convert the existing RulesLog class to a service and add a test case for it.
So:
- Let's implement https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-3-logg...
- Let's inject the core logger service, so we can forward messages above a configurable severity to the core logger
- Let's name the service rules.log
Comments
Comment #1
fagook, discussed it with klausi a bit more:
- Let's implement https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-3-logg...
- Let's inject the core logger service, so we can forward messages above a configurable severity to the core logger
- Let's name the service
rules.logComment #2
lussolucaI do a pull request here:
https://github.com/fago/rules/pull/122
Comment #3
a.milkovskyWe should use future settings from https://www.drupal.org/node/2471693 here
Comment #4
a.milkovskyComment #5
m1r1k commentedComment #6
m1r1k commentedLets separate Logging and Debugging:
Logging - separate LoggerChannel
Debuggin - integration for webprofiler module
Comment #7
fubhy commentedThe Logging Rewrite is done (https://github.com/fago/rules/pull/170) and was just merged. Next up: Integrating with web profiler (https://github.com/fago/rules/pull/175) - This one still needs some functional tests.
Comment #9
dasjoI'm unassigning this for now, feel free to pick it up whenever you have time to work on it.
Cheers, dasjo
Comment #10
fagoThis has been fixed, adding tests can be a follow-up.