Closed (won't fix)
Project:
Rules
Version:
8.x-3.x-dev
Component:
Rules Core
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
7 Oct 2014 at 11:44 UTC
Updated:
18 Jan 2015 at 16:26 UTC
Jump to comment: Most recent
Comments
Comment #1
kalman.hosszu commentedI started to work on it here: https://github.com/hosszukalman/rules/tree/feature/set-breadcrumb-action
Comment #2
fagoI guess the assignment is deprecated meanwhile? :-)
Comment #3
a.milkovskyI will work on it
Comment #4
a.milkovskyStarted working here: https://github.com/milkovsky/rules/tree/set-breadcrumb-2351979
I added repo of hosszukalman to remotes.
Why do we have SendMail.php here https://github.com/hosszukalman/rules/compare/feature/set-breadcrumb-action for this task?
Comment #5
dasjo@a.milkovsky the set-breadcrump-action feature branch from hosszukalaman was based accidentally based on another feature branch instead of 8.x-3.x.
Comment #6
fagoDiscussed this with a.milkovsky and fubhy. There is no drupal_set_breadcrumb() equivalence in d8 core any more - so we cannot easily provide an action for it. It's not the job of Rules to replicate this API - so if another module does so it can expose this action.
As breadcrumbs are really tied to routes in d8 and as they should be generated based upon page context, it seems to make sense to have something like this in page manager.
-> Setting as won't fix.
Comment #7
fagoComment #8
a.milkovskyI agree the breadcrumb system is different to one in drupal 7.
We can't set breadcrumb on the path that does't exist in routing. The issue can't be fixed without providing a fake route what is not a good way.
Let's leave this task to module that is more connected to routing. Would be good to implement in "Page manager" or port https://www.drupal.org/project/path_breadcrumbs to drupal 8.