Port "Fetch entity by property" action to D8 and rename it to "Fetch entity by field"

hey mariancalinro,
thank you for working on this! do you have code that you can share? please link it in the issue and update the assigned field if appropriate.

Hey dasjo, I'll grab this one and post a link once I have some work to show you.

Initial commit is here: https://github.com/diarmy/rules/tree/action-entity-fetch-9547355

Still lots to do obviously and I'll PR once it's ready for feedback.

cool, glad to see you back diarmy! :)

@diarmy, you can have a look at the similar Port "Fetch entity by id" action to D8. That might help ;-)

Hey @a.milkovsky,

That is immensely helpful, particularly the test setup(), so a huge thankyou!

@dasjo, it's good to be back.

Hi all

This is now ready for review: The PR is at https://github.com/fago/rules/pull/131

Many thanks.

setting to needs work based on the comments on the pull request

Hi guys, I've made a few updates in accordance with the comments so this is ready for review again.

Left a couple of comments on the pull request, mostly short array syntax. You should also merge in 8.x-3.x so that the travis ci tests pass again.

Thanks, klausi. I've made those short array syntax corrections and merged in 8.x-3.x.

Hi diarmy, could you update us about the status here? thanks

Unassigning for drupaldevdays sprints, the latest can be found here
https://github.com/diarmy/rules/branches

Hey dasjo, klausi pointed out a handful of array syntax issues last week which I corrected, so this may well be ready to merge. If not, please point out any other issues there may be with it. I am available to work on this today, so will re-assign to myself.

I've fixed the passing tests, new PR at https://github.com/fago/rules/pull/157 – could you take a look, maybe?

Mikl, I'll unassign as it looks like you are doing a great job. Good luck!

Ok, sorry for the confusion, I started working on it before your reply (#19) :)

It should all be done now, and the tests pass on Travis :)

Merged, thanks!

Re-opening for addressing the todo of refining provided entity context. Check the d7 info alter, implement like it's done for FetchEntityById (see refineContextDefinitions()) and add test coverage for it.

I've added a new pull request here: https://github.com/fago/rules/pull/294
I've added refineContextDefinitions() in the "fetch by id" action and tests for, also I've updated a found typo in testRefiningContextDefinitions in EntityFetchByFieldTest.
Please review.

Looks mostly good, but the tests are failing. Looks like you forgot to rename something in the test?

merge conflict in the pull request, can you resolve and push?

Fixed the merge conflict. Please review: https://github.com/fago/rules/pull/294

Almost ready, left a comment there!

Removed the unused use statement.

merged, thanks!