Action "Fetch entity by id" needs to be ported to Rules 8.x-3.x.

Comments

mirceatihu’s picture

mariancalinro’s picture

Issue summary: View changes
dasjo’s picture

Title: Port "Fetch entity by id" to 8.0.x » Port "Fetch entity by id" action to D8
dasjo’s picture

hey mirceatihu,
thank you for working on this! do you have code that you can share? please link it in the issue and update the assigned field if appropriate.

mirceatihu’s picture

hey dasjo,

I have some code here: https://github.com/stks/rules/tree/action_fetch_entity_by_id-2317199
the problem is that there are some errors when ruling the tests, I talked to mariancalinro and fago and it seemed that the problem was from the Drupal Core.

dasjo’s picture

Status: Active » Needs work
dasjo’s picture

Assigned: mirceatihu » Unassigned
a.milkovsky’s picture

Assigned: Unassigned » a.milkovsky

I will work on it

a.milkovsky’s picture

Issue tags: +SprintWeekend2015
a.milkovsky’s picture

a.milkovsky’s picture

Assigned: a.milkovsky » Unassigned
Status: Needs work » Needs review

Ready for review. PR: https://github.com/fago/rules/pull/130/files

For testing Please use Drupal version not newer than 1e985b0d32e5d6a180e. Otherwise all the tests are failed because of https://www.drupal.org/node/2413799.

  • klausi committed 1cfd7d3 on 8.x-3.x authored by a.milkovsky
    Issue #2317199 by a.milkovsky: Port "Fetch entity by id" action to D8.
    
klausi’s picture

Status: Needs review » Fixed

Comitted, thanks!

fago’s picture

Status: Fixed » Needs work

This misses implementation and tests for providing the right metadata for the provided variable.

a.milkovsky’s picture

Assigned: Unassigned » a.milkovsky

Ok, I will continue on it

diarmy’s picture

Hi Alex

Small issue in the comment for the FetchEntityById Constructor: it currently says 'Constructs a CreatePathAlias object', rather than 'Constructs a FetchEntityById object'.

a.milkovsky’s picture

@diarmy, Thanks. I will fix that. You can also leave the comments at https://github.com/fago/rules/pull/130/files

diarmy’s picture

Great, thanks. You might be interested to know that we spotted it at our Drupal meet-up in Glasgow, Scotland last night when looking at your code during a slideshow about #d8rules. :)

a.milkovsky’s picture

Assigned: a.milkovsky » Unassigned
Status: Needs work » Needs review

Created a pull request for the typo fix https://github.com/fago/rules/pull/152/files

This misses implementation and tests for providing the right metadata for the provided variable.

Else from #14 should be postponed for now.

a.milkovsky’s picture

Issue tags: +drupaldevdays
dasjo’s picture

Status: Needs review » Postponed

merged the typo fix from #19, thanks!

setting to postponed for "This misses implementation and tests for providing the right metadata for the provided variable"

a.milkovsky’s picture

We will need to implement also rules_entity_action_type_options.
Added todo to get entity types list in future.
Changed entity_type to entity_type_id for now.

https://github.com/fago/rules/pull/154

a.milkovsky’s picture

Status: Postponed » Needs review
a.milkovsky’s picture

Status: Needs review » Needs work

There are some comments in PR. Needs work.
I unassign myself because I am busy with https://www.drupal.org/node/2348839#comment-9816389

a.milkovsky’s picture

Assigned: Unassigned » a.milkovsky

In progress

a.milkovsky’s picture

Assigned: a.milkovsky » Unassigned
Status: Needs work » Needs review
fago’s picture

Status: Needs review » Needs work

See PR.

a.milkovsky’s picture

Assigned: Unassigned » a.milkovsky

  • klausi committed a6ee033 on 8.x-3.x authored by a.milkovsky
    Issue #2317199 by a.milkovsky: Renamed "Fetch entity by id" action
    
a.milkovsky’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.