Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Action "Fetch entity by id" needs to be ported to Rules 8.x-3.x.
Action "Fetch entity by id" needs to be ported to Rules 8.x-3.x.
Comments
Comment #1
mirceatihu CreditAttribution: mirceatihu commentedComment #2
mariancalinro CreditAttribution: mariancalinro commentedComment #3
dasjoComment #4
dasjohey mirceatihu,
thank you for working on this! do you have code that you can share? please link it in the issue and update the assigned field if appropriate.
Comment #5
mirceatihu CreditAttribution: mirceatihu commentedhey dasjo,
I have some code here: https://github.com/stks/rules/tree/action_fetch_entity_by_id-2317199
the problem is that there are some errors when ruling the tests, I talked to mariancalinro and fago and it seemed that the problem was from the Drupal Core.
Comment #6
dasjoComment #7
dasjoComment #8
a.milkovskyI will work on it
Comment #9
a.milkovskyComment #10
a.milkovskyContinued: https://github.com/milkovsky/rules/tree/action_fetch_entity_by_id-2317199
Comment #11
a.milkovskyReady for review. PR: https://github.com/fago/rules/pull/130/files
For testing Please use Drupal version not newer than 1e985b0d32e5d6a180e. Otherwise all the tests are failed because of https://www.drupal.org/node/2413799.
Comment #13
klausiComitted, thanks!
Comment #14
fagoThis misses implementation and tests for providing the right metadata for the provided variable.
Comment #15
a.milkovskyOk, I will continue on it
Comment #16
diarmy CreditAttribution: diarmy commentedHi Alex
Small issue in the comment for the FetchEntityById Constructor: it currently says 'Constructs a CreatePathAlias object', rather than 'Constructs a FetchEntityById object'.
Comment #17
a.milkovsky@diarmy, Thanks. I will fix that. You can also leave the comments at https://github.com/fago/rules/pull/130/files
Comment #18
diarmy CreditAttribution: diarmy commentedGreat, thanks. You might be interested to know that we spotted it at our Drupal meet-up in Glasgow, Scotland last night when looking at your code during a slideshow about #d8rules. :)
Comment #19
a.milkovskyCreated a pull request for the typo fix https://github.com/fago/rules/pull/152/files
Else from #14 should be postponed for now.
Comment #20
a.milkovskyComment #21
dasjomerged the typo fix from #19, thanks!
setting to postponed for "This misses implementation and tests for providing the right metadata for the provided variable"
Comment #22
a.milkovskyWe will need to implement also rules_entity_action_type_options.
Added todo to get entity types list in future.
Changed entity_type to entity_type_id for now.
https://github.com/fago/rules/pull/154
Comment #23
a.milkovskyComment #24
a.milkovskyThere are some comments in PR. Needs work.
I unassign myself because I am busy with https://www.drupal.org/node/2348839#comment-9816389
Comment #25
a.milkovskyIn progress
Comment #26
a.milkovskyUpdated the PR https://github.com/fago/rules/pull/154/files#r28253610
Comment #27
fagoSee PR.
Comment #28
a.milkovskyComment #30
a.milkovsky