Looks like a promising suite of modules, will be checking this out in the week. In the meantime, here's a patch for some code clean up as per drupal coding standards. Mostly tabs -> spaces and minor spacing issues, no 'real' code touched here.

CommentFileSizeAuthor
#1 role_subscription_262606-1.patch285.38 KBpfaocle

Comments

pfaocle’s picture

pfaocle
He/Him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new role_subscription_262606-1.patch285.38 KB
drupalninja99’s picture

drupalninja99 commented

Oh am I supposed to use tabs or spaces? I usually use tabs.

pfaocle’s picture

pfaocle
He/Him
Primary language English
commented

"Use an indent of 2 spaces, with no tabs. No trailing whitespace."

Yep!

drupalninja99’s picture

drupalninja99 commented

Ya I will do that at some point with a formatter thing. I've made a bunch of changes since your patch. I actually updated dev last night. I'm still figuring the drupal way of managing open source projects.

Here's a question while I have your undivided attention, how do I make a release such as my dev version show up with the little red x by it on my project page? Or do I have to tag it with something else? I wrongly uploaded the 1.0 build which shouldn't have been a 1.0 version so disregard that release.

pfaocle’s picture

pfaocle
He/Him
Primary language English
commented

You can control which releases show on the project page by editing your project, and checking out the options on the "releases" tab. I think "show snapshot release" is what you're after.

drupalninja99’s picture

drupalninja99 commented

Hmm I wonder if for the code cleanup if I just do a string replace where I replace \t with 3 spaces or 2 spaces or whatever for each file. I need to do that at some point soon.

pfaocle’s picture

pfaocle
He/Him
Primary language English
commented

Yes, if you can commit changes yourself there's not much point providing a patch. Just clean up via text-editor functions (eg search and replace \t -> 2 spaces etc). The changes will be available via CVS diff/cvslog once you commit.

drupalninja99’s picture

drupalninja99 commented

sounds good

drupalninja99’s picture

drupalninja99 commented
Status: Needs review » Closed (won't fix)

sorry not going to make any fixes, this module has been deprecated