Closed (fixed)
Project:
Revive Adserver
Version:
8.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
22 Mar 2019 at 09:33 UTC
Updated:
16 Aug 2019 at 09:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
efpapado commentedProposing patch.
Comment #3
efpapado commentedComment #4
szeidler commentedHi,
thanks for creating the issue and proposing a patch.
I can confirm this.
This is actually not true, but maybe not that super obvious. In that case you need to specify the invocation method on the "Manage display" settings of your entity. Then there will not be a fatal error.
But I agree, that a global setting could make sense here and such a fatal error should not happen in any case. Then there wouldn't be any further configuration required on the per-block or per-entity base.
Comment #5
szeidler commentedAttaching a patch, that tests the given scenario. It should fail and will be used to prove that the patch #2 is fixing the issue.
Comment #6
szeidler commentedAnd a patch with proper test and patch #2 included. That should ideally pass successfully.
Comment #8
szeidler commentedNew test against the current dev, using the new test trait.
Comment #9
efpapado commentedYou're right, I missed it!
Nice work with the tests :)
Comment #10
szeidler commentedWe agreed in a side-disussion, that it should be enough, just to make sure, that the fallback field formatter is the "Async" method, simply because we expect it to be the most used one. That will prevent the fatal error.
We should document this behavior and also fact, that the Invocation method can be changed on the "Manage display" field formatter level.
A global invocation method is nice, but we don't see much use-cases, where someone would choose for example "iframe" globally for the site.
Comment #11
szeidler commentedComment #12
szeidler commentedComment #13
szeidler commentedHere's a patch for using the "async_javascript" method as a defaultsetting. If the test returns green, the fatal error should not happen anymore.
Comment #15
szeidler commentedMerged into the dev-release. Thanks for the contribution!