Problem/Motivation

According to PHPStan, the code-base could use some slight tweaks to get it D9/D10 ready.

Steps to reproduce

Run PHP Stan against the code-base

Proposed resolution

Adjust the code to address the issues.

Issue fork restfullogger-3262552

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rymcveigh created an issue. See original summary.

rymcveigh opened merge request !5

rymcveigh’s picture

rymcveigh
he/him/his
commented
Status: Active » Needs review

The PHPStan code recommendations have been addressed in the MR and are ready for review.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Reviewed & tested by the community

LGTM!

  • rymcveigh committed ad6ef56 on 8.x-1.x 
    Issue #3262552 by rymcveigh: Ensure code is D9/D10 ready
rymcveigh’s picture

rymcveigh
he/him/his
commented
Status: Reviewed & tested by the community » Fixed

  • rymcveigh committed ad6ef56 on 2.x 
    Issue #3262552 by rymcveigh: Ensure code is D9/D10 ready

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.