Needs review
Project:
Premium Responsive
Version:
7.x-1.6
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
4 Jul 2012 at 09:42 UTC
Updated:
1 Mar 2013 at 17:57 UTC
Jump to comment: Most recent file
Comments
Comment #1
devsaran commentedFor SSL,
You need to do code changes in style.css.. Change from
to
Comment #2
Homotechsual commentedYou can also download the font packages from Google Web Fonts and host these locally to reduce cross-site requests.
Comment #3
alibama commentedconfirmed that #1 works fine - any reason not to commit this or is there a better solution all together?
Thanks
ap
Comment #4
Homotechsual commentedThe reason not to commit this is that not everyone wants SSL webfonts. This needs to become a theme option if it's committed with a simple on/off switch.
Failing that - bundle the google webfonts used into the theme. This is permitted as most google webfonts are GPL licensed afaik.
Comment #5
danny englanderActually the proper way to do this so it will work with secure and non secure sites is to take off the http(s) entirely. It's best done as a template preprocess function. For example:
I'm not sure if this will work as @import though. I solved a recent issue for my theme this way:
#1921294: Google Fonts cause unsecure warnings when using SSL
Comment #6
Homotechsual commentedhighrockmedia That's great advice!
Comment #7
danny englanderGoing to open this back up to supply a proper patch when I have some time.
Comment #8
danny englanderHere is a patch for this. If we could get someone to test this with SSL, it would be great. I tested and did not have any issues but I did not have an SSL environment to test with. However, it should be fine otherwise.
Also to saran.quardz, the maintainer of this theme, when you commit this patch, please be sure to give proper attribution as such:
--author="highrockmedia <highrockmedia@406120.no-reply.drupal.org>"You need to pass this option to
git commitIf you have questions about this, see: Adding a commit author
Thank you.
Comment #9
danny englanderUpdating patch to include all the fonts that had been in style.css (added 'Bitter'). Disregard the patch from #8 above.