Closed (fixed)
Project:
Require Login
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
11 Apr 2013 at 20:24 UTC
Updated:
11 May 2014 at 10:50 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
mvd81NL commentedCreated a patch to fix this.
Comment #2
eelkeblokHi,
Thanks for the patch. I did have some trouble getting it applied automatically through drush make (phpStorm was able to figure it out, I think drush make needs the a/ and b/ prefixes to the file versions), so I re-rerolled it from my Git clone. Please find attached.
To the maintainer, may I kindly draw your attention to Commit message guidelines, I saw most of your commit messages don't follow them. No biggy, never a bad day to learn something new, right?
This patch also gives rise to maybe some re-factoring that becomes apparent; there are a few more tests on arg() values, which could easily move to the newly introduced excluded path function. Also, the sole purpose of the stack of ifs seems to be adding more conditions, so they could actually be handled in a single if-statement. The Drupal coding guidelines have a thing or two to say about keeping monstrous if-statements readable, see https://drupal.org/coding-standards#controlstruct, specifically under the heading "Line length and wrapping". All this does seem out of scope for this issue, though. Marking as RTBC, since the changes I added to the patch are minor.
Comment #4
Jeffrey C. commentedHello there,
Thank you all for the contribution. The issue has been fixed in the latest commit/release.