Reset password links are not working, takes user back to login page. Also when you disable the module permissions are messed up and no one can access the site so once it's installed there's no getting rid of it.

Comments

mvd81NL’s picture

StatusFileSize
new1.04 KB

Created a patch to fix this.

eelkeblok’s picture

Issue summary: View changes
Status: Active » Reviewed & tested by the community
StatusFileSize
new1.05 KB

Hi,

Thanks for the patch. I did have some trouble getting it applied automatically through drush make (phpStorm was able to figure it out, I think drush make needs the a/ and b/ prefixes to the file versions), so I re-rerolled it from my Git clone. Please find attached.

To the maintainer, may I kindly draw your attention to Commit message guidelines, I saw most of your commit messages don't follow them. No biggy, never a bad day to learn something new, right?

This patch also gives rise to maybe some re-factoring that becomes apparent; there are a few more tests on arg() values, which could easily move to the newly introduced excluded path function. Also, the sole purpose of the stack of ifs seems to be adding more conditions, so they could actually be handled in a single if-statement. The Drupal coding guidelines have a thing or two to say about keeping monstrous if-statements readable, see https://drupal.org/coding-standards#controlstruct, specifically under the heading "Line length and wrapping". All this does seem out of scope for this issue, though. Marking as RTBC, since the changes I added to the patch are minor.

  • Commit d2e239e on 7.x-1.x by Jeffrey C.:
    Issue #1968148 by ralva83638, mvd81NL, eelkeblok: Restore reset password...
Jeffrey C.’s picture

Status: Reviewed & tested by the community » Fixed

Hello there,

Thank you all for the contribution. The issue has been fixed in the latest commit/release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.