Hi, sometimes when deleting something in Drupal I'll get a message like "Relations 14 have been deleted." - That doesn't really tell me anything. Could it say something like "The relation between content My Page and user Frank was removed" instead?

CommentFileSizeAuthor
#8 ambiguous-notices-2707835-1.patch792 byteskapil.ropalekar
#6 ambiguous-notices-2707835-1.patch792 byteskapil.ropalekar
#3 ambiguous-notices-2707835.patch1.58 KBkapil.ropalekar

Comments

danielb created an issue. See original summary.

danielb’s picture

danielb commented
Title: Ambigious notices » Ambiguous notices
kapil.ropalekar’s picture

kapil.ropalekar commented
StatusFileSize
new ambiguous-notices-2707835.patch1.58 KB

Hi danielb,

The Available source bundles during creation of a Relation are dependent on the entity types.
Thus displaying the type and its title as part of the drupal_set_message during deletion will cause extra loading of all entity types.

I have created a patch which will list the titles of all bundles present in a particular Relation when it gets deleted.

Now instead of the message 'Relations 14 have been deleted.', it will show 'The relation between "My Page, Frank" was removed'.

Kindly review it.

kapil.ropalekar’s picture

kapil.ropalekar commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: ambiguous-notices-2707835.patch, failed testing.

kapil.ropalekar’s picture

kapil.ropalekar commented
Status: Needs work » Needs review
StatusFileSize
new ambiguous-notices-2707835-1.patch792 bytes

Updated patch file.

Status: Needs review » Needs work

The last submitted patch, 6: ambiguous-notices-2707835-1.patch, failed testing.

kapil.ropalekar’s picture

kapil.ropalekar commented
Status: Needs work » Needs review
StatusFileSize
new ambiguous-notices-2707835-1.patch792 bytes
mikran’s picture

mikran commented

the last patch only changes whitespace?