CommentFileSizeAuthor
#1 registration-enable reminder template for all nodes-2495307-1.diff797 bytesjmickela

Comments

jmickela’s picture

jmickela
he/him
Location SF Bay Area, California
commented
StatusFileSize
new registration-enable reminder template for all nodes-2495307-1.diff797 bytes

This patch moves the code for setting the default reminder template outside of the if statement that checks if the reminder is enabled by default.

göran’s picture

göran commented
Issue summary: View changes

Doesen't this means that the Promoter not can decide if, or keep track of who has, be/been announced? Or?

jmickela’s picture

jmickela
he/him
Location SF Bay Area, California
commented

I don't think I understand the question.

The only change here is that the template text is filled in all the time instead of not copying the template text if sending a reminder is disabled by default. Generally speaking the expected behavior when you create default items is that they will be used exactly when creating new items, currently if you have reminders off by default but do have a default template, the default template isn't used.

göran’s picture

göran commented

Sry, this question don't belong here, it is related to a thread about "the registred right's to decided IF they shall receive message". Some miss match on thread? - SRY (My fault - to many windows opend in my browser)

P.S. - But it's a very good explanation about this patch:s function know in this issue know, so the damage is positive ;)
and i will try it.

göran’s picture

göran commented

I can't get the patch to work, did try it on a the latest dev version.
There is a code in a line of the patch that i cant find in the code in /includes/registration.forms.inc

- $fields['reminder_template'] = $values['reminder']['reminder_settings']['reminder_template'];

Please advice.

john.oltman’s picture

john.oltman commented
Status: Active » Closed (outdated)