Strict warning: Only variables should be passed by reference in registration_form()

Patch also applies cleanly to registration (7.x-1.1) and solves the warning.

@caktux, please set the status of an issue to 'needs review' if you attach a patch!

MrHaroldA,

What did you change in the patch file (if anything) to apply this to 7.x-1.1? I tried patching the module and got the following error:

Ashleys-MacBook-Air:registration ash$ patch < registration-strictwarning.patch --dry-run
can't find file to patch at input line 5
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|Index: includes/registration.forms.inc
|===================================================================
|--- includes/registration.forms.inc (revision 4702)
|+++ includes/registration.forms.inc (working copy)
--------------------------
File to patch: c

Perhaps you should have used the -p or --strip option?

Well ... did you? ;) Please try -p1.

It's generally much easier with git anyway:

wget [URL of patch]
git apply [patch file]

Speaking of which, here's a re-roll.

It's not changed functionally, so setting it back to RBTC.

I tried a couple of -p options but I'm fairly new to all of this so I don't think I did it correctly. Is the patch file supposed to be in the main folder for the registration module or in the includes folder? Maybe that is where I'm getting stuck.

Generally the patch file should be in the project folder, at the top level.

Also, I set my patch to 'needs review' in hopes that the automated test would run. I guess that's not enabled for this project.

Thanks, Mile23! I'll give it a try today. I have no idea about the needs review -> automation but I hope that it gets reviewed ;-)

Patch applies fine for me!

I was receiving the same error in the COD Distribution. Patch applied cleanly please commit :)

Patch applies for me and resolves the issue.

Patch works like a charm. Thanks!

Worked well for me too

Already fixed in 2852f18a543328ec47e27d6f4ea59ef879153218.