Problem/Motivation

After implementing #3397584: Turbo: Behaviours are often not attached if the script containing the behaviour finishes downloading/is evalutated after Turbo has rendered the new page, it's become clear that there are a number of behaviours which aren't written to properly handle the whole body being replaced and then cause errors when attached again after a detach.

Steps to reproduce

Load various site pages with Turbo active, and navigate by clicking various links; observe eventual console errors to various things.

Proposed resolution

Contribute fixes to core and contrib projects.

Drupal core

Remaining tasks

TBD.

User interface changes

Stuff should be more reliable.

API changes

None.

Data model changes

None.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 3399243-tabledrag Comparecompare

Comments

Ambient.Impact created an issue. See original summary.

ambient.impact’s picture

Issue summary: View changes

Added Gin list item with Claro CSS being incorrectly used.

ambient.impact’s picture

ambient.impact’s picture

ambient.impact’s picture

Issue summary: View changes

Added core/misc/announce.js list item.

ambient.impact’s picture

Issue summary: View changes

Added code link for contextual links item.

ambient.impact’s picture

Issue summary: View changes

Added core/misc/batch.js item.

ambient.impact’s picture

Issue summary: View changes

Marked the core/misc/announce.js item as complete.

  • ambient.impact committed c680d866 on 2.x
    Issue #3399243: Updated JavascriptAlterTest to fix announce.js failure...
ambient.impact’s picture

  • ambient.impact committed 86b6a44d on 2.x
    Issue #3399243: Added complete rewrite of core's dropbutton.js:
    
    This is...

  • ambient.impact committed 86b6a44d on 2.0.x
    Issue #3399243: Added complete rewrite of core's dropbutton.js:
    
    This is...

  • ambient.impact committed 86b6a44d on cache-and-lazy-preloader
    Issue #3399243: Added complete rewrite of core's dropbutton.js:
    
    This is...
ambient.impact’s picture

Issue summary: View changes

Added dropbutton and table select.

  • ambient.impact committed bb0f4048 on 2.x
    Issue #3399243: Further fixes and improvements to overridden dropbutton.
    

  • ambient.impact committed bb0f4048 on 2.0.x
    Issue #3399243: Further fixes and improvements to overridden dropbutton.
    

  • ambient.impact committed 21848eae on cache-and-lazy-preloader
    Issues #3399243 & #3411449: Detach dropbuttons before cache.
    

  • ambient.impact committed 88d557b6 on cache-and-lazy-preloader
    Issue #3399243: Added Gin dropbutton replacement.
    

  • ambient.impact committed bb0f4048 on cache-and-lazy-preloader
    Issue #3399243: Further fixes and improvements to overridden dropbutton.
    

  • ambient.impact committed e2f04048 on cache-and-lazy-preloader
    Issue #3399243: Fix Gin sticky region behaviour when showing cached.
    

  • ambient.impact committed a270fbae on cache-and-lazy-preloader
    Issue #3399243: Fix core & Gin table select when showing cached.
    

  • ambient.impact committed 7ed09ef0 on cache-and-lazy-preloader
    Issues #3399243 & #3411449: Dropbutton: event namespace on before cache.
    

  • ambient.impact committed af2f29b7 on cache-and-lazy-preloader
    Issues #3399243 & #3411449: Fix incorrect dropbuttons dependencies.
    
ambient.impact’s picture

Issue summary: View changes

Completed dropbutton and table select.

ambient.impact’s picture

Issue summary: View changes

Set contextual and core Navigation as completed.

  • ambient.impact committed 2354bbc9 on cache-and-lazy-preloader
    Issue #3399243: Remove core Navigation patch to try before cache event.
    

  • ambient.impact committed a1c04a89 on cache-and-lazy-preloader
    Revert "Issue #3399243: Remove core Navigation patch to try before cache...
ambient.impact’s picture

Issue summary: View changes

Added media grid table select item.

  • ambient.impact committed e2f04048 on 2.x
    Issue #3399243: Fix Gin sticky region behaviour when showing cached.
    

  • ambient.impact committed 7ed09ef0 on 2.x
    Issues #3399243 & #3411449: Dropbutton: event namespace on before cache.
    

  • ambient.impact committed af2f29b7 on 2.x
    Issues #3399243 & #3411449: Fix incorrect dropbuttons dependencies.
    

  • ambient.impact committed e2f04048 on 2.0.x
    Issue #3399243: Fix Gin sticky region behaviour when showing cached.
    

  • ambient.impact committed 7ed09ef0 on 2.0.x
    Issues #3399243 & #3411449: Dropbutton: event namespace on before cache.
    

  • ambient.impact committed af2f29b7 on 2.0.x
    Issues #3399243 & #3411449: Fix incorrect dropbuttons dependencies.
    

ambient.impact’s picture

Issue summary: View changes

ambient.impact’s picture

Issue summary: View changes

Added tabledrag.js item and marked tableselect.js more or less fixed.

ambient.impact’s picture

Issue summary: View changes

  • ambient.impact committed a6f4cd2c on 2.x
    Issue #3399243: Added compatibility/media_library.click_to_select.js.
    
ambient.impact’s picture

Issue summary: View changes

Added Media Library items.

  • ambient.impact committed a6f4cd2c on 2.0.x
    Issue #3399243: Added compatibility/media_library.click_to_select.js.