Hi,

I found one unused placeholder @space, which I have added in patch. Also I have added coupon code in format coupon as most of the time we also want to know what was the code we have applied earlier.

CommentFileSizeAuthor
#6 unused_placeholder-2895040-6.patch794 bytesmarkdorison
#2 unused_placeholder-2895040-2.patch2.2 KBnarendrar

Comments

NarendraR created an issue. See original summary.

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Active » Needs review
StatusFileSize
new unused_placeholder-2895040-2.patch2.2 KB
markdorison’s picture

markdorison
he/him
commented
Status: Needs review » Reviewed & tested by the community

markdorison’s picture

markdorison
he/him
commented
Status: Reviewed & tested by the community » Fixed
markdorison’s picture

markdorison
he/him
commented
Status: Fixed » Needs review
StatusFileSize
new unused_placeholder-2895040-6.patch794 bytes

Patch in #2 introduced code style issue. Fixed that here; no functional changes.

  • markdorison committed f92cbf3 on 8.x-1.x 
    Issue #2895040 by NarendraR, markdorison: Unused placeholder @space in...
narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented

Hi Mark,

I suppose changes of file RecurlyRedeemCouponForm.php is also required, as without these changes, it does not give correct message.
Let me know if I need to do something here.

markdorison’s picture

markdorison
he/him
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.