Problem/Motivation
There are some unnecessary dependencies on the node and views modules that have snuck into this module.
Proposed resolution
The dependency on node comes from the access content permission specified in the routing file. Since rating already has its own permissions the voting controller can be refactored to check that permission instead.
The views dependency is trickier, and comes from the vote tab that displays on /node/{node}/results. This can be removed by moving the tab configuration to the view itself, and moving the view to config/optional so it gets installed when views and node are enabled.
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | rate-remove_dependencies-2879915-2.patch | 341 bytes | lamp5 |
Issue fork rate-2879915
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
lamp5Comment #4
ivnishComment #7
atul_ghate commentedComment #8
ivnishNeeds reroll MR to 3.2.x branch and needs to fix tests
Comment #9
ivnish