When using the "quote selected" feature, the link only becomes active once some text is selected on the page. However, the selection is detected globally: selecting text in the node body enables the "quote selected" links on every comment (and vice versa), instead of enabling only the link under the element where the selection was actually made. This also leads to a wrong attribution bug: if a user selects text in the node body and then clicks the "quote selected" link on a comment, the selected node text is inserted into the comment form, but the quote is attributed to the author of that comment. The same applies to the "reply and quote selected" link. The expected behavior is that a "quote selected" link becomes active only when the selection is inside the content of the node or the specific comment the link belongs to.

Issue fork quote-3623601

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

ivnish created an issue. See original summary.

  • ivnish committed adef9810 on 4.2.x
    task: #3623601 "Quote selected" link is enabled for all nodes/comments...
ivnish’s picture

Assigned: ivnish » Unassigned
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.