There is an unpleasant effect - buttons are moving when red border appears. This happens because red border makes them larger then they were before.

I propose to use border: 1px solid transparent; in ed_button style by default to prevent this effect.

Thank you.

CommentFileSizeAuthor
#4 moving-buttons-patch352 bytessshvetsov

Comments

Bèr Kessels’s picture

Bèr Kessels commented

Good observation,
Problem is that on most sites I had the styles overriden in the sites theems anyway. This needs to be solved in the default css too.

ardas’s picture

ardas commented

Sorry, but I didn't understand you. Did you mean in default CSS quicktags or Drupal default CSS ?
I wonder, is there anything else should be changed to properly fix this bug for default behaviour ?

Bèr Kessels’s picture

Bèr Kessels commented

no, only quicktags.css needs to be fixed.

sshvetsov’s picture

sshvetsov commented
Status: Active » Needs review
StatusFileSize
new moving-buttons-patch352 bytes

I noticed that this problem hasn't been fixed yet. Here's the patch. I just changed the line like Duke suggested.

neclimdul’s picture

neclimdul
He/Him
commented
Status: Needs review » Fixed

This looks to have been fixed.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)