Problem/Motivation

The changes from the Pipelines issue broke the tab memory feature.

Specifically this one line change == to ===:
$link.data('myTabIndex') === $cookieValue

$link.data('myTabIndex') - int
$cookieValue - string

Proposed resolution

Convert $cookieValue to integer with parseInt($cookieValue)

CommentFileSizeAuthor
#4 0001-Updated-tab-memory-issue.patch1.86 KBharitha c
Screenshot 2025-04-14 at 18.41.32.png96.8 KBanwaikurn

Issue fork quicktabs-3519116

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anwaikurn created an issue. See original summary.

haritha c made their first commit to this issue’s fork.

haritha c opened merge request !43

haritha c’s picture

haritha c commented
Status: Active » Needs review
StatusFileSize
new 0001-Updated-tab-memory-issue.patch1.86 KB

I have fixed the tab memory issue by converting $cookieValue to an integer using parseInt($cookieValue, 10).

The fix is committed in the branch 3519116-tab-memory-feature.

Patch is also uploaded.
https://git.drupalcode.org/issue/quicktabs-3519116/-/tree/3519116-tab-me...

Please review.

anwaikurn’s picture

anwaikurn commented

Thank you for the MR, but you should not add .patch file to the commit.

anwaikurn’s picture

anwaikurn commented
Status: Needs review » Needs work
haritha c’s picture

haritha c commented

Thank you for your comment. I've removed the .patch file from the updated code repository.

haritha c’s picture

haritha c commented
Status: Needs work » Needs review

smustgrave’s picture

smustgrave commented
Version: 4.0.1 » 4.0.x-dev
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.