Problem/Motivation
The Tab History feature was implemented in https://drupal.org/project/quicktabs/issues/3035749. An option should exist for this feature to be enabled/disabled. When using the Ajax option to load only one tab on page load for performance reasons, it does not make much sense to then immediately load another tab, given the default and the last tab clicked are different tabs, but some people may want that ability. Furthermore, some people may not want this feature at all, and always load the default tab. So, I do not suggest associating the option with the Ajax option.
Proposed resolution
Create a new boolean option to enable the Tabs History feature. This option would be enabled by default to keep the existing functionality. Help text should describe the purpose of the both enabling and disabling the option.
Remaining tasks
- Create a new option on the entity form labeled, "Tabs History".
- Use the new option to determine whether or not to load the last clicked tab, or the default tab.
- Add the new option to the schema.
User interface changes
The entity options form will have a new radio button field, and help text describing the options.
API changes
None
Data model changes
None
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 3390978-tab-history-option-2.patch | 3.73 KB | nmangold |
Issue fork quicktabs-3390978
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3390978-add-an-option
changes, plain diff MR !15
Comments
Comment #3
nmangold commentedComment #4
nmangold commentedComment #5
smustgrave commentedLets add some test coverage.
Comment #7
smustgrave commented#3189439: Last clicked tab history should be configurable