Closed (outdated)
Project:
Quick Tabs
Version:
7.x-3.6
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 May 2014 at 14:00 UTC
Updated:
11 Dec 2024 at 16:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
joey-santiago commentedThe problem happens only when the empty tab is not the last one. It happens then that
Drupal.settings.quicktabs[qtKey].tabs.length
is undefined, so this loop in JS doesn't work:
haven't found a way to patch that yet. it's bugging me a lot.
Comment #2
joey-santiago commentedI think the problem is that when the tabs are initialized in JS, the ids of the elements are not synchronized with the php information sent to Drupal.settings.quicktabs:
this sets tabIndexes based on the html created, but the object Drupal.settings.quicktabs has different indexes set on the configuration of the tabs so having the empty placeholders for the empty tabs.
Comment #3
joey-santiago commentedHere's a patch.
Comment #4
jncrucesThanks!!
Your patch works.
Only the change of tab now reload the page, bug i have not time to correct it.
Edit:
I found this issue related that not produces a page reload:
https://www.drupal.org/node/2108935
Comment #5
smustgrave commentedWith D7 EOL approaching in a month I'm starting to triage the D7 side of quicktabs queue. This doesn't appear to have any code so believe this may not make it, sorry! Thanks though!
If still an issue or needed for 4.0.x (latest branch) feel free to reopen