Use a better hash for uniqueness

Here's the basics of a patch to fix this.

Yes, good point about the column name - I had that thought too. Possibly the value saved in the hash column should have a prefix indicating the hash used? That would allow a more seamless transition in the future to a different hash algo?

The problem with injecting the serialization service is that the \Drupal\Core\Queue\DatabaseQueue::claimItem() method would then also need to be reimplemented. I think that should be postponed to another issue and/or proposed for the core queue class?

Here's a quick update to make the column and method naming more generic. If you wanted to change to e.g sha3, it could be done with no update hook if you are willing to accept possible duplicate items in the queue from before the module update.

Would probably be helpful here to figure out a test of the update hook, or at least I'll want to verify it.

@e0ipso - sure, but as a general standard you want about 256 bits of the hash for really robust collision resistance, so 32 chars is too short. Thus, I'd keep the column length at 47 or 48 chars (so about 43 chars of 6 bit hash).

Quick update

Partial test of update hook - needs more to check conversion of existing items.

Here are improvements to the 1st test method. It had one actual bug fixed. Still need to wrap the new test method up.

The fixed bug in the test was this line at the end:

    // With the original item being gone we should be able to readd an item
    // with the same data.
    $item_id = $queue->createItem($item_id);

It's passing in $item_id instead of $data

Ok, I think this is complete enough in terms of test coverage.

trivial change - removes unused use statement from the test class.

Updated patch and interdiff.

excellent, thanks!