As parasolx indicated in the original feature request, the patch doesn't work. The problem is twofold: first $mailkey is never actually initialized in drupal_mail_wrapper; second, the $message object contains the mailkey from drupal_mail with an additional suffix tacked on. The attached patch does the following:

  1. drupal_mail_wrapper looks for $message['id'] (which is in the format module_name_mailkey_name)
  2. Altered the method for checking the message id against the user-defined exclusion list
  3. Appended the $message['id'] to the Job Queue description (so the end-user can see what kind of messages are queued).
  4. Modified queue_mail_settings_form to refer to "Message Ids" instead of mailkeys
  5. Included the names of two common 6.x message ids
CommentFileSizeAuthor
queue_mail-mailkeyfix.patch2.24 KBjonathan webb

Comments

rastarr’s picture

rastarr commented

Subscribing - can this patch be verified and rolled into this module please?

parasolx’s picture

parasolx commented
Status: Needs review » Reviewed & tested by the community

+1, its work..
brilliant and kindly to commit into next dev

but i found one thing.
the field is using normal text field which restrict to 255 long
if can exchange to textarea so can insert more mailkey such as logintobaggon module

parasolx’s picture

parasolx commented
Status: Reviewed & tested by the community » Needs review
arski’s picture

arski commented

yes, dammit, that's some silly design - creating a field where lots of ids may be entered and then having it limited to 255 chars.. :/

cor3huis’s picture

cor3huis commented
Priority: Normal » Major

Bumped, since a solution is provided and only one bug left, Maintainer get the glory of your module having ZERO bugs (Jay!) and integrate this patch. :-)

parasolx’s picture

parasolx commented
Category: bug » feature

does this consider as bug? cause the patches already work.
just left to make the field extend from 225 to handle more mailkey.

so i mark this as feature request.

cor3huis’s picture

cor3huis commented

Your are right indeed, good catch, thanks!. It would however IMHO it would make sense to have change in main sourcecode.

mcurry’s picture

mcurry commented

Can we get this patch rolled into an official release?

mcurry’s picture

mcurry commented
Status: Needs review » Fixed

Oops, it appears the original patch to fix the original isseue report is already in the -dev build. Correct?

I've created an issue (#1072232: queue_mail_key config item limited to 128 characters; should be longer, or a textarea for easier editing) for the length limitation, so we should close this issue if the patch has been applied to the -dev branch. We should continue the length limitation discussion in #1072232: queue_mail_key config item limited to 128 characters; should be longer, or a textarea for easier editing.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.