Running under XAMPP with PHP 5.3.8, this generates a warning and then subsequently fails to generate a proper key, causing the cache mechanism to fail. AFAICT there is no reason the genMultiKey function needs to to be protected, and if it does need to be then the methods that call it cannot try to invoke it as a static function.

The following patch changes the function declaration to be public static so that calls won't fail under PHP 5.3 and newer (and is the correct declaration for how this function is being used in the module).

CommentFileSizeAuthor
#1 querypath-genMultiKey-1607050-01.patch446 bytesarpieb

Comments

arpieb’s picture

arpieb commented
Status: Active » Needs review
StatusFileSize
new querypath-genMultiKey-1607050-01.patch446 bytes

... and here's the patch.

mbutcher’s picture

mbutcher commented
Status: Needs review » Fixed

Fixed and committed. Thanks for the patch. I'm also adding you as a committer to QueryPath -- I've seen your work, and I trust your judgement. Feel free to commit other bugfixes at will.

arpieb’s picture

arpieb commented

Thanks! Will do...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.