On the config form is found the following help text:
"The default password for all nodes. This password is necessary if you select the previous checkbox."
There is no "previous checkbox". It is not clear when a password is necessary.

CommentFileSizeAuthor
#10 protected_node-password_help_text-2572465-10.patch31.2 KBdrupalove
#5 protected_node-password_help_text-2572465-5.patch13.7 KBdrupalove
#4 protected_node-password_help_text-2572465-4.patch12.24 KBdrupalove
#2 protected_node-password_help_text-2572465-2.patch1.5 KBdrupalove

Comments

John_B created an issue. See original summary.

drupalove’s picture

drupalove commented
Status: Active » Needs review
StatusFileSize
new protected_node-password_help_text-2572465-2.patch1.5 KB

I've attached a small patch with improved help text.

drupalove’s picture

drupalove commented

It seems other parts of the help text need improvement. Will submit another patch soon.

drupalove’s picture

drupalove commented
StatusFileSize
new protected_node-password_help_text-2572465-4.patch12.24 KB

More changes in the attached patch.

drupalove’s picture

drupalove commented
StatusFileSize
new protected_node-password_help_text-2572465-5.patch13.7 KB

Further text improvement, hopefully the last one :) Thanks for this module.

john_b’s picture

john_b commented

Thanks for the patch!

john_b’s picture

john_b commented
Status: Needs review » Reviewed & tested by the community

I read the code, applied with git and checked on a local environment (Acquia Dev Desktop on Windows). Looks good.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Reviewed & tested by the community » Needs work

Hello,

Thanks for the patches. Here is my review.

  1. +++ b/protected_node.settings.inc
@@ -432,40 +432,44 @@ function protected_node_admin_settings() {
+    '#description' => t('Selecting the global password option makes it possible to protect nodes using one password which must be provided in the \'Global password\' fields below.

    Use doublequote in t function to avoid using backslash. 

  2. +++ b/protected_node.settings.inc
@@ -432,40 +432,44 @@ function protected_node_admin_settings() {
+       // "When checked, the global password is used if the user doesn't enter a password when creating/editing nodes.") . t("<strong>WARNING:</strong> removing the global password when many pages were not otherwise assigned a password will make those nodes unaccessible except for UID=1 and the author of the node."),

    Do not keep commented line in the patch if it must be removed. 

  3. +++ b/protected_node.settings.inc
@@ -694,7 +698,7 @@ function protected_node_admin_settings() {
+    '#description' => '<span style="color: red;">' . t('WARNING: this function resets all the individual passwords and will assign the global password to all protected nodes.') . '</span>',

    Instead I will use: WARNING: this function deletes all the individual passwords. Make sure to have authorized the use of global password.

    As it is what really happen.

Also, These changes should be done in protected_node.variable.inc

drupalove’s picture

drupalove commented
Assigned: Unassigned » drupalove

@John_B, thanks for testing.

@Grimreaper, thanks for the review I agree with what you say.

I'll make the changes later today.

drupalove’s picture

drupalove commented
Assigned: drupalove » Unassigned
Status: Needs work » Needs review
StatusFileSize
new protected_node-password_help_text-2572465-10.patch31.2 KB

Here's an updated patch which covers the protected_node.variable.inc and protected_node.info files.

  • Grimreaper committed dc60fb5 on 7.x-1.x authored by drupalove 
    Issue #2572465 by drupalove, John_B, Grimreaper: confusing help text
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Needs review » Fixed

Thanks,

This is now merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.