The protected node configuration available on the node edit page is confusing for the following reasons:

  1. When the content type is set to "Always protected", the help text on the node edit form still indicates that a checkbox is available when it actually isn't.
  2. The "Show Title" checkbox only matters when the default description text is used. It has no effect when a custom description text is set.
CommentFileSizeAuthor
#3 protected_node-node_edit_settings-2537898-3.patch6.87 KBdigitgopher
#1 protected_node-node_edit_settings-2537898-1.patch3.08 KBdigitgopher

Comments

digitgopher’s picture

digitgopher commented
Status: Active » Needs review
StatusFileSize
new protected_node-node_edit_settings-2537898-1.patch3.08 KB

Resolution:
1. Move the description text to the checkbox it is for.
2. Hide the show title option if other text will be displayed regardless.

I thought about other permissions checks or text to display when the checkbox is hidden, but didn't think we needed anything else. What do you think?

As always, please let me know if I did anything wrong! Thanks.

Status: Needs review » Needs work

The last submitted patch, 1: protected_node-node_edit_settings-2537898-1.patch, failed testing.

digitgopher’s picture

digitgopher commented
Status: Needs work » Needs review
StatusFileSize
new protected_node-node_edit_settings-2537898-3.patch6.87 KB

Well clearly I didn't test that. Let's try this again.

Status: Needs review » Needs work

The last submitted patch, 3: protected_node-node_edit_settings-2537898-3.patch, failed testing.

digitgopher’s picture

digitgopher commented

Nice, it works now.

Status: Needs work » Needs review

digitgopher queued 3: protected_node-node_edit_settings-2537898-3.patch for re-testing.

digitgopher’s picture

digitgopher commented

Re-testing after #2534644: fix tests for bulk actions feature marked as fixed...

Status: Needs review » Needs work

The last submitted patch, 3: protected_node-node_edit_settings-2537898-3.patch, failed testing.

digitgopher’s picture

digitgopher commented

My mistake, it fails concerning #2447913: Fix fork feature, fork rather than bulk. Anyway, I will wait for a review now.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Needs work » Fixed

Hello,

This is merged now. Thanks.

Notices:
- inline comments and phpdoc comments should not have more than 80 characters on the same line
- don't forget space before parenthesis in "if () {"
- variable names should not be in camelcase (in D7)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.