Closed (fixed)
Project:
Protected Node
Version:
7.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
13 Mar 2015 at 19:56 UTC
Updated:
30 Mar 2015 at 15:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
damienmckennaThis is based off node_admin_nodes().
Comment #2
grimreaperHello,
Thanks for the patch. Nice idea.
I wonder if we should create one permission similar to "access content overview" to be able to access this page.
Comment #3
izus commentedHi,
the 'translation' module is not maintained and is replaced with 'entity_translation'
about the list access :
i think it should be accessible for roles that "bypass password protection", actually even a title that is not supposed to be accessed by anyone can sometimes be considered as "information disclosure"
what do you guys think about it ?
Thanks
Comment #4
damienmckennaFYI I took most of the code from core, so that's core's logic on the admin/content/node page.
Comment #5
grimreaperHello,
For the access, a new permission or "bypass password protection" as you want.
For the "translation" or "entity_translation", I see 3 options:
- keeping the same thing as in core, and when the core will update this line, we will update our.
- Using entity_translation, I test, no problem.
- putting the code from protected_node_views in protected_node and using views to provide a BO page, so it will be customizable (access, content, etc.)
The page works but the absence of filters and bulk operations orients me to the third option.
Comment #6
izus commentedfinally , i think we should add a check for translation module too
module_exists('translation') || module_exists('entity_translation')as some old site may still have it (and also core still have this (does that worth a core task ?))consider it RTBTC for me after this, so you can merge it and have this feature in, yeah !
Comment #8
grimreaperOk, merged.
Thanks you all.