Implement tests for protected node

With global password, the view of the node fail. It is "normal", it is related to this issue https://drupal.org/node/2266507

I lost a lot of time in these tests because at the beginning I used :

// Create a protected node.
    $settings = array(
      'protected_node_is_protected' => TRUE,
      'protected_node_show_title'   => TRUE, // To be removed here to follow the test.
      'protected_node_emails'       => '',    // To be removed here to follow the test.
    );
    $node = $this->drupalCreateNode($settings);

To create node. But the protected node module stored nothing and I realised that when I wrote the tests for per node password. I was fooled because the assertText was on the nodes' title and its were shown even on the password form even when it fails.

So now I use the node's body.

I also lost a lot of time before founding that :

'protected_node_use_global_password'          => array(PROTECTED_NODE_GLOBAL_PASSWORD),

To set the password method was not good. No need of an array.

Now It should be good for those basic tests.

I wait your feedbacks.

Thanks for the review.

For the tests in each file. I forgot to mention that I also want that, but I don't know the proper way to make that.

Ok, let's focus on password per node. While my first patch is not lost it's ok. :)

I will see that this weekend.

This patch only tests password per node. Creation and view.

The tests are in their own file.

I remade the previous patch to respect some coding style standards of POO and comments.

Your version is much clearer. :)

I just had messages on the asserts to locate them easily among the debug messages.

Now I understand better how you wanted the tests to be organized.

About the notice, I already have it in the patch at #2266507-2: Global password does not work properly

If it's ok, I will wait the first test to be merged. Then I will rebase #2266507-2: Global password does not work properly and write the other tests in this issue.

Hum, no... the $group in #13 is more like the name of the test function, that's how I thought them when I wrote them.

I don't think the $group should be feature specific as a feature is already in (its own file and) its own class. So in the UI of testing, it's easy to separate them.

And as I retest to see the impact in the UI. I just realize that for assertresponse there is no $group... So I add this new patch...

So, ok, If you want something global; global $group = 'Protected node' ?

I think the name of project or the name of the module, therefore the submodules will be hightlighted.

a global variable or a constant ?

Ok.

Add $this->group = 'Protected node'; in test's setup().

Remove protected $adminuser and protected $normaluser in ProtectedNodeBaseTestCase as they are useless.

Hoping it will be good this time :)

Do you prefer a patch (containing tests) per feature or a patch with tests for several features ?

Hi,

Here is a patch that add tests for per content type protection.

Thanks for the review.

Hello,

I add a test about the email. So this patch contains both protected_node.per_type.test and protected_node.mail.test

But I don't know why protected node does not detect anymore the tests in protected_node.per_type.test.

Hello,

emails

1. $this->group = 'Protected node'; : I don't know if it is possible to put something that is in the method getInfo in the setup method. And there is no heritance of getInfo method.
   

   Note: Do not declare a getInfo() or any test methods (e.g. testExample()) in your parent class (MyModuleWebTestCase above). Doing so will cause errors.

   from https://www.drupal.org/node/583030

2. ok
3. $this->group : it's for debug messages. In the getInfo it's for the global organization of tests as you can see in the testing UI.

per type

1. renamed in page_content_type_password
2. is viewing

I attached a patch containing the two tests. As well as two patches with the tests separated.

Thanks for the review.

Hi,

Sorry to have forgotten to warn you about the devel problem. I also got it and I was also surprised of that.

Sorry for the coding style problems, I thought my IDE was well configured. It seems not..., maybe I configured for one project and not globally. :(

Updating issue summary.

Updating issue summary has test for global password feature has been postes here : https://www.drupal.org/node/2266507#comment-9062857

Updating issue summary.

Hiding files. Sorry for double post.

Hello,

I manually test the cardinality tests.

I found that with the core with the upload widget you can use a file in only one place (or I miss something).

Therefore to be able to use a file in several places, I enable file_entity and media modules. Using the media selector widget.

With the default file_entity and media permissions as file_entity add the specific permission "view private files", checked for anonymous user by default.

I test that if a private file is added in an unpublished unprotected node, anonymous user can't access the file with the URL. Ok, normal.

I test that if the same file is added to a publish protected node, anonymous user is then redirected to the password form and if he/she enters the correct password he/she gains access to the file. OK, normal.

I think I am going to write those tests. But I wonder, should I make another separated files for the test as it requires file_entity and media or use the current test file for private files ?

I also wonder if those tests are relevant, as it use contributed modules and the contributed modules on media management can have different approaches.

Waiting your go Izus to write those tests.

Here is a patch that add tests on statistics.

Hello,

I attach a patch to add test for the bulk actions. I have started with the "clear sessions" action.

Thanks for the review.

Hello,

Unfortunately no, there are still tests to implement.

I update the issue summary.

Add test for remove protection.

Add test for restore protection.

Fix issue markup.

Add tests for use global password.

Add test for reset passwords action.

Add test for protect node action.

About the falling test for reset password action. If someone can test it locally, I will be very thankful. I think I will open an issue that will regroup the test falling on the testbot.

Add test for private file reused across multiple nodes.

Let's debug the two remaining tests that do not pass on the testbot.

And now both tests pass!!!??? Are you kidding me testbot? lol.

So, could we close the issue?

For https://www.drupal.org/node/2179473#comment-8744327, Yeah, very lucky :), no code fix needed

It was the test added with https://www.drupal.org/node/2277045#comment-10092610, do you see another test for that feature ?

I begin to feel the pleasure to close an issue that has been opened more than an year ago :D

Hello digitgopher,

I had to merge a last change. I waited any comment.

As nobody sees another test to implements since one week. I close the issue.

I update the issue summary so it is clear there is nothing more to do.

Thanks all.