Protected Node Statistics block renders empty. The block uses the #value key rather than #markup.

The attached patch corrects that issue and converts the block to use the theme_table function rather than appending html to form the table.

CommentFileSizeAuthor
#3 protected_node-statistics-1506324-3.patch5.61 KBizus
protected_node-statistics.patch6.51 KBbarrett

Comments

idflood’s picture

idflood commented
Status: Needs review » Reviewed & tested by the community

Patch looks good and is working well. There is just an empty line at the top of protected_node_admin_settings which could have been removed but I don't think this needs a new patch only for that.

zilverdistel’s picture

zilverdistel commented
Status: Reviewed & tested by the community » Needs work

I have only one remark: 

+++ b/protected_node.settings.incundefined
@@ -231,35 +231,111 @@ function protected_node_node_form_alter(&$form) {
+  // any nodes?

Code standards should be followed for new patches. Comments should start with a capital and end with a punctuation character ('.', '?', ...).
See http://drupal.org/node/1354 for more details on code comments.

I created a new issue for existing problems concerning the drupal coding standards: http://drupal.org/node/1598330.

Using a theme function for the table is an excellent improvement!

Thanks,

Diederik

izus’s picture

izus commented
Issue summary: View changes
StatusFileSize
new protected_node-statistics-1506324-3.patch5.61 KB

hi,
i reworked and rebased the patch tobe ok for the last code base, i will merge it in minutes but uploading it here FYI

izus’s picture

izus commented
Status: Needs work » Fixed

merged,
Thank you all for help !

izus’s picture

izus commented

also deleted the '»' . in the patch

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.