Planafolio Finanzrechner embeds 19 free finance calculators for German investors (ETF savings plan, compound interest, capital gains tax, Vorabpauschale, pension gap, withdrawal, FIRE, inflation, rebalancing, XIRR, TTWROR and more) from planafolio.com into Drupal sites.

It provides:

  • A block plugin ("Planafolio calculator") with settings for calculator, theme, language, initial height, two-click privacy mode and an optional source link.
  • A text filter ("Planafolio calculators") that replaces [planafolio sparplanrechner] in text formats with a calculator; optional attributes theme, lang and height.
  • A two-click privacy mode, enabled by default: nothing is loaded from planafolio.com until the visitor clicks "Load calculator". Placeholder texts follow the calculator language (German or English).
  • A small JavaScript that loads the iframe on click and adjusts its height via postMessage, accepting messages only from https://planafolio.com.

The module stores no data and sends nothing from the Drupal backend. All output is rendered through a Twig template; attributes from the text filter are whitelisted (theme, lang, height) and calculator names are validated against a fixed list.

Project link

https://www.drupal.org/project/planafolio_finanzrechner

Comments

planafolio created an issue. See original summary.

avpaderno’s picture

Assigned: planafolio » Unassigned
Issue summary: View changes

Thank you for applying!

Before giving links helpful to understand how the review process works, what to expect from a review, and what to do to avoid a review takes more time than needed, I would like to thank all the reviewers for the work they do.
These applications are volunters-driven, which also means it is not possible to predict when an application will be marked fixed and the applicant will get the permission to opt projects into security advisory policy. While we aim to make an application as quick as possible, it is also important for us that more people review the project used for an application. In this way, we make sure applications do not miss some important points that should be instead reported.
Applications are not meant to be complete debugging sessions that eliminate every existing bug, though. I apologize if sometimes applications seem to go into too-detailed reviews.

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

The important notes are the following.

  • If you have not done it yet, you should enable GitLab CI for the project and fix the PHP_CodeSniffer errors/warnings it reports.
  • For the time this application is open, only your commits are allowed.
  • The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status will not be changed by this application; once this application is closed, you will be able to change the project status from Not covered to Opt into security advisory coverage. This is possible only 14 days after the project is created.

    Keep in mind that once the project is opted into security advisory coverage, only Security Team members may change coverage.
  • Only the person who created the application will get the permission to opt projects into security advisory coverage. No other person will get the same permission from the same application; that applies also to co-maintainers/maintainers of the project used for the application.
  • We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.

The important notes are the following.

  • It is preferable to wait for a project moderator before posting the first comment on newly created applications. Project moderators will do some preliminary checks that are necessary before any change on the project files is suggested.
  • For the tools to use for reviewing a project, see Tools to use for reviews.
  • It may be best to have the applicant fix things before further reviews and avoid doing a review when another review is pending.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.

avpaderno’s picture

Status: Needs review » Needs work

Usually, after reviewing a project, we allow the developer to opt projects into security advisory coverage. This project is too small for us; it does not contain enough Drupal-related PHP code to really assess your skills as a developer.

Do you have any other project hosted on drupal.org that we could instead review? It needs to have most of the commits (but preferably all the commits) done by you, in at least a branch.