Conditional Notification sends messages when entities are saved. What is
sent, to whom and under which conditions lives in content rather than in
code: a notification template carries the subject, the body, its conditions
and its deliveries, and a per-entity override adjusts or suppresses that
template for one event, course or group without touching the original.

Conditions and deliveries are plugins, so a site adds its own without
patching the module. Conditions combine with AND and OR and may be
time-based — "once the event has ended" is a condition here, not a cron
script of your own: the module records the affected entity and template
pairs and re-evaluates them on cron, and it sends once. Delivery runs
through two queues with a retry per recipient, so one refused address costs
that address a retry rather than everyone else a duplicate.

Channels are submodules: e-mail through Symfony Mailer, so Mailer Policy
applies; SMS through Symfony Notifier transports, with the credentials read
from Key entities. A Group integration resolves memberships to their group
and delivers to its members, an ECA bridge lets a model decide a condition
or perform a delivery, and templates can be exported and imported to move
them between sites. Recipients are deduplicated per channel, messages are
translatable, and personal data is kept out of the logs.

Project link

https://www.drupal.org/project/conditional_notification

Comments

daniel.pernold created an issue. See original summary.

vishal.kadam’s picture

Issue summary: View changes
avpaderno’s picture

Thank you for applying!

Before giving links helpful to understand how the review process works, what to expect from a review, and what to do to avoid a review takes more time than needed, I would like to thank all the reviewers for the work they do.
These applications are volunters-driven, which also means it is not possible to predict when an application will be marked fixed and the applicant will get the permission to opt projects into security advisory policy. While we aim to make an application as quick as possible, it is also important for us that more people review the project used for an application. In this way, we make sure applications do not miss some important points that should be instead reported.
Applications are not meant to be complete debugging sessions that eliminate every existing bug, though. I apologize if sometimes applications seem to go into too-detailed reviews.

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

The important notes are the following.

  • If you have not done it yet, you should enable GitLab CI for the project and fix the PHP_CodeSniffer errors/warnings it reports.
  • For the time this application is open, only your commits are allowed.
  • The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status will not be changed by this application; once this application is closed, you will be able to change the project status from Not covered to Opt into security advisory coverage. This is possible only 14 days after the project is created.

    Keep in mind that once the project is opted into security advisory coverage, only Security Team members may change coverage.
  • Only the person who created the application will get the permission to opt projects into security advisory coverage. No other person will get the same permission from the same application; that applies also to co-maintainers/maintainers of the project used for the application.
  • We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.

The important notes are the following.

  • It is preferable to wait for a project moderator before posting the first comment on newly created applications. Project moderators will do some preliminary checks that are necessary before any change on the project files is suggested.
  • Reviewers should show the output of a CLI tool only once per application.
  • It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.

avpaderno’s picture

Status: Needs review » Needs work

For these applications, we need a project where, in at least a branch, most of the commits (but preferably all the commits) have been done from the person who created the application.

The purpose of these applications is reviewing a project to understand what the person who applies understands about writing secure code which follows the Drupal coding standards and correctly uses the Drupal API, not what all the project maintainers collectively understand about those points.

Do you have a project for which most of the commits have been done by you in at least a branch? It also needs to contain enough Drupal-related-PHP code.

avpaderno’s picture

It should be globexplorer who applies using the Conditional Notification project, since he has more than 100 commits in that project. If the purpose of this application is just making that project covered by Drupal’s security advisory policy, that would be the solution.