This module enables Drupal website administrators to add the TrustArc Cookie Consent Manager to their site.

Project link

https://www.drupal.org/project/trustarc

Comments

hyebahi created an issue. See original summary.

vishal.kadam’s picture

Issue summary: View changes
avpaderno’s picture

Title: [1.0.3] Trustarc » [main] Trustarc

Thank you for applying!

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

The important notes are the following.

  • If you have not done it yet, you should enable GitLab CI for the project and fix the PHP_CodeSniffer errors/warnings it reports.
  • For the time this application is open, only your commits are allowed.
  • The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status will not be changed by this application; once this application is closed, you will be able to change the project status from Not covered to Opt into security advisory coverage. This is possible only 14 days after the project is created.

    Keep in mind that once the project is opted into security advisory coverage, only Security Team members may change coverage.
  • Only the person who created the application will get the permission to opt projects into security advisory coverage. No other person will get the same permission from the same application; that applies also to co-maintainers/maintainers of the project used for the application.
  • We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.

The important notes are the following.

  • It is preferable to wait for a project moderator before posting the first comment on newly created applications. Project moderators will do some preliminary checks that are necessary before any change on the project files is suggested.
  • Reviewers should show the output of a CLI tool only once per application.
  • It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.

avpaderno’s picture

Status: Needs review » Needs work

For these applications, we need a project where, in at least a branch, most of the commits (but preferably all the commits) have been done from the person who created the application.

The purpose of these applications is reviewing a project to understand what the person who applies understands about writing secure code which follows the Drupal coding standards and correctly uses the Drupal API, not what all the project maintainers collectively understand about those points.

Do you have a project for which most of the commits have been done by you in at least a branch? It also needs to contain enough Drupal-related-PHP code.

hyebahi’s picture

Hi @avpaderno

Thank you again for your review and guidance.

This module provides a basic setup form, loads the TrustArc script based on that configuration, and injects the required TrustArc container divs in the page output.

To be transparent: I have not yet made significant contributions to public Drupal projects.
One of my colleagues also helped me with code review. I personally implemented the changes, ran the tools, fixed the issues reported, and pushed the commits.

Current status:
- Local quality checks are passing using these tools/checks:
- GitLab CI (DrupalCI template)
- PHPCS (Drupal + DrupalPractice)
- ESLint
- Prettier
- drupal-check
- PHPStan
- Composer audit
- cspell
- Docker-based reproducible validation workflow
- The CI pipeline is currently being executed after the latest pushes/merges.

Would that suffice to get the code reviewed?

Thank you,
Haissam

hyebahi’s picture

Status: Needs work » Needs review