Needs review
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
19 Mar 2026 at 14:00 UTC
Updated:
30 Mar 2026 at 21:10 UTC
Jump to comment: Most recent
Comments
Comment #2
vishal.kadamComment #3
avpadernoThank you for applying!
Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.
The important notes are the following.
Keep in mind that once the project is opted into security advisory coverage, only Security Team members may change coverage.
To the reviewers
Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.
The important notes are the following.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.
Comment #4
avpadernoFor these applications, we need a project where, in at least a branch, most of the commits (but preferably all the commits) have been done from the person who created the application.
The purpose of these applications is reviewing a project to understand what the person who applies understands about writing secure code which follows the Drupal coding standards and correctly uses the Drupal API, not what all the project maintainers collectively understand about those points.
Do you have a project for which most of the commits have been done by you in at least a branch? It also needs to contain enough Drupal-related-PHP code.
Comment #5
hyebahi commentedHi @avpaderno
Thank you again for your review and guidance.
This module provides a basic setup form, loads the TrustArc script based on that configuration, and injects the required TrustArc container divs in the page output.
To be transparent: I have not yet made significant contributions to public Drupal projects.
One of my colleagues also helped me with code review. I personally implemented the changes, ran the tools, fixed the issues reported, and pushed the commits.
Current status:
- Local quality checks are passing using these tools/checks:
- GitLab CI (DrupalCI template)
- PHPCS (Drupal + DrupalPractice)
- ESLint
- Prettier
- drupal-check
- PHPStan
- Composer audit
- cspell
- Docker-based reproducible validation workflow
- The CI pipeline is currently being executed after the latest pushes/merges.
Would that suffice to get the code reviewed?
Thank you,
Haissam
Comment #6
hyebahi commented