[D7] Twitter Feed Block

Hi shantanu2683,

Here are some quick issues to get started:

- You should delete your master branch, according to https://drupal.org/empty-git-master
- 7.x-1.0 branch doesn't match the release branch pattern. It should be 7.x-1.x
- All variables defined by your module must be prefixed with your module's name to avoid name collisions with others.

Also, please take a look at the automated code review results here:
http://pareview.sh/pareview/httpgitdrupalorgsandboxshantanu26832167827git

Hi,

Great module, just a little pointer from me:

within twitterAuth.inc you seem to have @author tags, whereas these aren't needed in Drupal contrib, please remove.

Other than that, great module!

Cheers,
Adam

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,

What does this module do, that any of the very many other Twitter modules does not do? Could this functionality be added to an existing module instead of creating a new one?

Can you provide a list of the other Twitter modules on Drupal.org and a short (1-3 sentance) comparison between each and your module? There really are quite a few Twitter modules and it's difficult to tell from the description how yours is different. Thanks!

So this sounds like an improvement that should live in the existing twitter_block project. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the twitter_block issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "needs review".

Sure, but you should contribute to the existing module instead of creating yet another twitter module.

I don't understand the difference to twitter_block, could you describe that exactly on the project page so that users know which module to choose?

Same for the other existing projects, differences are missing on the project page:
https://drupal.org/project/twitter
https://drupal.org/project/twitter_pull

I would like to ask you one more time to contribute to those existing modules, because it is very likely that one of those already does exactly what you want.

Please add the differences to the existing modules I mentioned to the project page of your module.

Removing review bonus tag, you have not done any manual review, you just copied the output of an automated review tool. Make sure to read through the source code of the other projects, as requested on the review bonus page.

Your clone link does not work:

git clone --branch 7.x-1.0 http://git.drupal.org/sandbox/shantanu2683/2167827.git

I got the error:

fatal: Remote branch 7.x-1.0 not found in upstream origin
Unexpected end of command stream

It should be:
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/shantanu2683/2167827.git twitter_feed_block

I decided the clone link not working was not a reason to change the projects status so set back to what it was.

On another note I too do also feel that there are already too many twitter modules and think improving what is there is a better option that releasing more.

There is already:

• Twitter
• Twitter Feed
• Twitter Pull
• Twitter Block
• Tweet Button (different functionality I know)

I personally created a twitter module and starting going through the process of getting it published but realised that there were already a lot of options available so abandoned it (but still use it for my personal projects).

Hi. I did a quick code review of what you have and what the other modules do.

Here's what I see:

Twitter Feed Block - It authenticates with twitter's 1.1 API to create two block types 1. list of tweets that match a search term, 2. list of users recent tweets and displays them in overrideable theme functions.

Twitter Block - basically just the javascript version that twitter provides as a widget - i.e. it looks how twitter wants you to brand it. Definitely not the same.

Twitter Feed - This does everything that 'Twitter Feed Block' does, except it exposes the results to views. So you could replicate this modules functionality by creating views blocks. It is severely limited in that there is only one search query configurable for the whole module, not per block.

Twitter Pull - provides pretty much identical functionality to this module, yet provides more features. The comment in https://drupal.org/node/2169353#comment-8482155 is incorrect. It relies on the http://drupal.org/project/twitter module to handle the authentication, and you most certainly can do search blocks with it.

This is pretty much a duplicate (not a copy!) of what other modules can already accomplish, with no real new functionality, and only subtle differences in implementation.

Look at the code for Twitter Pull. It is a Feed, not a widget, utilizing the twitter API in the same way that your module does.

You can also pull in a feed of tweets using the Feeds module along with Feeds OAuth. Although, that isn't Twitter-specific...

Getting a lot of Notices from Twitter block after entrying values mentioned in below screenshot.

It seems proper validations are not in place.

Also its GIT's admin call to promote this project as this seems to be a duplicate.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi Shantanu, i have gone through your Tweet feed block module find out few things this should be address

1) can u please write info file into below formate.
name = "Tweet feed block"
description = "Tweet feed block to show twitter feed on block"
core = "7.x"
package = Twitter feed
configure = admin/config/services/tweet-feed-setting

stylesheets[all][] = css/twitter_feed_block.css
2) When i click on Help link which is available right next to module name in
Structure -> Module -> Tweet feed block. Then it redirect to README link even if i click on "README" link it displays nothing, only one "UP" link display which redirect me to the same "README" page.

3) Can we make $request_method = 'POST'; instead of $request_method = 'GET'; So our requests can have more data length.
4) There is steel some issue is to manage :
http://pareview.sh/pareview/httpgitdrupalorgsandboxshantanu26832167827git

> Twitter Pull - provides pretty much identical functionality to this module, yet provides more features. The comment in https://drupal.org/node/2169353#comment-8482155 is incorrect. It relies on the http://drupal.org/project/twitter module to handle the authentication, and you most certainly can do search blocks with it.

Also, Twitter Pull could probably do with a new maintainer :)

I agree with "joachim" on his comment "Twitter Pull - provides pretty much identical functionality to this module, yet provides more features.."

Manual Review

Secure code

No: List of security issues identified.]
See comment #37 #2169353-37: [D7] Twitter Feed Block
Have a look at this https://www.drupal.org/writing-secure-code

Duplication

This sounds like a feature that should live in the existing Twitter Pull project. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the Twitter Pull issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "needs review".

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.