The "StackEdit" module provides a WYSIWYM text editor inspired by WMD editor used in StackOverflow site.

  • Provides Markdown filter integration for Drupal input formats.
  • Syntax-hightlighting is applied to code blocks.
  • A toolbar is added to textarea when StackEdit is selected as text format. Every button is associated to a keyboard shortcut.
  • Special url like nid:// and uid:// are converted to link to nodes and users.
  • Quick preview is provided by an ajax call.
  • Textarea increases height to fit content, also when typing

Project:

StackEdit sandbox project
This module is for Drupal 7.

Installation

Clone from git repository:
git clone --recursive --branch 7.x-1.x http://git.drupal.org/sandbox/alessandro.pezzato/1835986.git stackedit

You also need external libraries:

Download `google-code-prettify` from
and extract the content of `distrib` directory into `libraries` directory.

Download http://google-code-prettify.googlecode.com/files/prettify-small-1-Jun-20...

    tar jxvf prettify-small-1-Jun-2011.tar.bz2 -C libraries
    rm -r prettify-small-1-Jun-2011.tar.bz2

Clone also submodule (jquery.hotkeys)

    git submodule status      # show repository's submodules

    git submodule init        # initialize local configuration

    git submodule update      # fetch all the data from submodules

Snapshot:

Screenshot

CommentFileSizeAuthor
Screenshot72.55 KBAlessandro Pezzato

Comments

Alessandro Pezzato’s picture

Alessandro Pezzato commented
Issue summary: View changes

fix screenshot url

vineet.osscube’s picture

vineet.osscube commented

Hi,
Firstly there is lots of issue regarding line spaces, indentation & comments.

Look at this !
http://ventral.org/pareview/httpgitdrupalorgsandboxalessandropezzato1835...

Here you can check source code whether it meets drupal coding standards or not, and advise you what to change in your code. You can repeat review after your commits, and can fix those errors.

vineet.osscube’s picture

vineet.osscube commented

Manual Review :

1) Please don't add LICENSE.txt, it will be added by drupal community after completing review process and full project release.

2) Use L() function to make your links in line no 19, 20 in stackedit.help.inc & line 67 in stackedit.text_filter.inc

3) Do not add "?>" PHP delimiter at the end of files is discouraged in ./libraries/markdown/markdown.php.

Alessandro Pezzato’s picture

Alessandro Pezzato commented

I've done some fixes in my code, but external code in the libraries directory is out of my control. It's here because there is not a simple way to download it all. Is there any way to make code reviewer ingnoring all "libraries" directory?

Alessandro Pezzato’s picture

Alessandro Pezzato commented
Issue summary: View changes

fix git command, screenshot to the end, external libraries installation

pere orga’s picture

pere orga
Primary language Catalan
commented

I don't know for sure if the module is ready to be a full project, but after reviewing it I don't see any problems with it.

Just one thing, it's better to not include any javascript library, you should encourage users to use the common libraries directory instead. That way the files can be shared across modules.

mohs3n71’s picture

mohs3n71 commented
Status: Needs review » Needs work

Hi
first ) see this automatic review : http://ventral.org/pareview/httpgitdrupalorgsandboxalessandropezzato1835...
there are many erorrs ...
you must see drupal coding standards : http://drupal.org/node/318

second ) if you are using external libraries you must use libraries module : https://drupal.org/project/libraries and add this module as a dependency in your .info file and in your project page give a link to users to download the libraries and put them in the libraries folder this is very better way

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue summary: View changes

changed git clone command