[D6] Domain Login

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• Run coder to check your style, some issues were found (please check the Drupal coding standards):
  

  Severity minor, Drupal Commenting Standards, Internationalization, Drupal Security Checks, Drupal SQL Standards, Drupal Coding Standards
  
  sites/all/modules/pareview_temp/test_candidate/domain_login.module:
   +3: [normal] use a space between the closing parenthesis and the open bracket
   +13: [normal] use a space between the closing parenthesis and the open bracket
   +18: [normal] use a space between the closing parenthesis and the open bracket
   +20: [normal] Control statements should have one space between the control keyword and opening parenthesis
   +20: [normal] use a space between the closing parenthesis and the open bracket
   +22: [normal] else statements should begin on a new line
   +23: [normal] Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
   +27: [normal] use a space between the closing parenthesis and the open bracket
   +29: [normal] String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms
   +32: [normal] use a space between the closing parenthesis and the open bracket
   +33: [normal] Control statements should have one space between the control keyword and opening parenthesis
   +33: [normal] use a space between the closing parenthesis and the open bracket
   +36: [normal] Control statements should have one space between the control keyword and opening parenthesis
   +36: [normal] use a space between the closing parenthesis and the open bracket
   +39: [normal] Control statements should have one space between the control keyword and opening parenthesis
   +39: [normal] use a space between the closing parenthesis and the open bracket
   +40: [normal] String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms
   +40: [normal] missing space after comma
   +52: [normal] String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms
   +62: [normal] use a space between the closing parenthesis and the open bracket
   +63: [normal] Control statements should have one space between the control keyword and opening parenthesis
   +63: [normal] use a space between the closing parenthesis and the open bracket
  
  Status Messages:
   Coder found 1 projects, 1 files, 22 normal warnings, 0 warnings were flagged to be ignored
  

• README.txt is missing, see the guidelines for in-project documentation.
• Remove "project" from the info file, it will be added by drupal.org packaging automatically.
• All text files should end in a single newline (\n). See http://drupal.org/node/318#indenting
  

  ./domain_login.module ./js/domain_login.js
  

This automated report was generated with PAReview.sh, your friendly project application review script. Go and review some other project applications, so we can get back to yours sooner.

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• README.txt is missing, see the guidelines for in-project documentation.
• Remove "project" from the info file, it will be added by drupal.org packaging automatically.
• All text files should end in a single newline (\n). See http://drupal.org/node/318#indenting
  

  ./domain_login.module ./js/domain_login.js
  

This automated report was generated with PAReview.sh, your friendly project application review script. Go and review some other project applications, so we can get back to yours sooner.

Source: http://ventral.org/pareview - PAReview.sh online service

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• Run coder to check your style, some issues were found (please check the Drupal coding standards):
  

  Severity minor, Drupal Commenting Standards, Internationalization, Drupal Security Checks, Drupal SQL Standards, Drupal Coding Standards
  
  sites/all/modules/pareview_temp/test_candidate/domain_login.module:
   +22: [normal] else statements should begin on a new line
   +23: [normal] Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
   +40: [normal] missing space after comma
  
  Status Messages:
   Coder found 1 projects, 1 files, 3 normal warnings, 0 warnings were flagged to be ignored
  

• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards):
  

  
  FILE: ...view/sites/all/modules/pareview_temp/test_candidate/domain_login.module
  --------------------------------------------------------------------------------
  FOUND 25 ERROR(S) AND 1 WARNING(S) AFFECTING 17 LINE(S)
  --------------------------------------------------------------------------------
    2 | ERROR   | Missing file doc comment
    3 | ERROR   | Missing function doc comment
    3 | ERROR   | Expected 1 space between the closing parenthesis and the
      |         | opening brace; found 0
   13 | ERROR   | Missing function doc comment
   13 | ERROR   | Expected 1 space between the closing parenthesis and the
      |         | opening brace; found 0
   18 | ERROR   | Missing function doc comment
   18 | ERROR   | Expected 1 space between the closing parenthesis and the
      |         | opening brace; found 0
   20 | ERROR   | Expected "if (...) {\n"; found "if(...){\n"
   23 | ERROR   | TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
      |         | found "false"
   27 | ERROR   | Missing function doc comment
   27 | ERROR   | Expected 1 space between the closing parenthesis and the
      |         | opening brace; found 0
   29 | ERROR   | TRUE, FALSE and NULL must be uppercase; expected "NULL" but
      |         | found "null"
   29 | ERROR   | Concat operator must be surrounded by spaces
   29 | ERROR   | Concat operator must be surrounded by spaces
   32 | ERROR   | Missing function doc comment
   32 | ERROR   | Expected 1 space between the closing parenthesis and the
      |         | opening brace; found 0
   33 | ERROR   | Expected "switch (...) {\n"; found "switch(...){\n"
   36 | ERROR   | Expected "if (...) {\n"; found "if(...){\n"
   39 | ERROR   | Expected "if (...) {\n"; found "if(...){\n"
   40 | ERROR   | No space found after comma in function call
   40 | ERROR   | Concat operator must be surrounded by spaces
   45 | WARNING | A comma should follow the last multiline array item. Found: )
   52 | ERROR   | Concat operator must be surrounded by spaces
   62 | ERROR   | Missing function doc comment
   62 | ERROR   | Expected 1 space between the closing parenthesis and the
      |         | opening brace; found 0
   63 | ERROR   | Expected "if (...) {\n"; found "if(...){\n"
  --------------------------------------------------------------------------------
  
  
  FILE: ...eview/sites/all/modules/pareview_temp/test_candidate/js/domain_login.js
  --------------------------------------------------------------------------------
  FOUND 26 ERROR(S) AFFECTING 26 LINE(S)
  --------------------------------------------------------------------------------
    2 | ERROR | Spaces must be used to indent lines; tabs are not allowed
    3 | ERROR | Spaces must be used to indent lines; tabs are not allowed
    4 | ERROR | Spaces must be used to indent lines; tabs are not allowed
    5 | ERROR | Spaces must be used to indent lines; tabs are not allowed
    6 | ERROR | Spaces must be used to indent lines; tabs are not allowed
    7 | ERROR | Spaces must be used to indent lines; tabs are not allowed
    8 | ERROR | Spaces must be used to indent lines; tabs are not allowed
    9 | ERROR | Spaces must be used to indent lines; tabs are not allowed
   10 | ERROR | Spaces must be used to indent lines; tabs are not allowed
   11 | ERROR | Spaces must be used to indent lines; tabs are not allowed
   12 | ERROR | Spaces must be used to indent lines; tabs are not allowed
   13 | ERROR | Spaces must be used to indent lines; tabs are not allowed
   14 | ERROR | Spaces must be used to indent lines; tabs are not allowed
   15 | ERROR | Spaces must be used to indent lines; tabs are not allowed
   16 | ERROR | Spaces must be used to indent lines; tabs are not allowed
   17 | ERROR | Spaces must be used to indent lines; tabs are not allowed
   18 | ERROR | Spaces must be used to indent lines; tabs are not allowed
   19 | ERROR | Spaces must be used to indent lines; tabs are not allowed
   20 | ERROR | Spaces must be used to indent lines; tabs are not allowed
   22 | ERROR | Spaces must be used to indent lines; tabs are not allowed
   24 | ERROR | Spaces must be used to indent lines; tabs are not allowed
   25 | ERROR | Spaces must be used to indent lines; tabs are not allowed
   26 | ERROR | Spaces must be used to indent lines; tabs are not allowed
   27 | ERROR | Spaces must be used to indent lines; tabs are not allowed
   28 | ERROR | Spaces must be used to indent lines; tabs are not allowed
   29 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  --------------------------------------------------------------------------------
  

• README.txt is missing, see the guidelines for in-project documentation.
• Remove "project" from the info file, it will be added by drupal.org packaging automatically.
• All text files should end in a single newline (\n). See http://drupal.org/node/318#indenting
  

  ./js/domain_login.js ./domain_login.module
  

This automated report was generated with PAReview.sh, your friendly project application review script. Go and review some other project applications, so we can get back to yours sooner.

Source: http://ventral.org/pareview - PAReview.sh online service

Switched back to needs review, so in-depth reviews won't be blocked by coding standart issues.

Updating git clone info

Review of the 6.x-1.x-dev branch:

• ./domain_login.module: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  

  function domain_is_valid($subdomain) {
  function domain_load_subdomain($subdomain) {
  

• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Go and review some other project applications, so we can get back to yours sooner.

manual review:

• wrong branch name, "6.x-1.x-dev" should be "6.x-1.x".
• domain_login_lookup_domain_ajax_callback(): you should use drupal_json() here.
• domain_login.js: do not use "jQuery(document).ready(function(){", use Drupal.behaviors. See http://drupal.org/node/304258
• This module might be too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code cannot be seriously reviewed. However, we can promote this single project manually to a full project if you wish. Please fix the remaining issues first.