Agile development of relational-database backoffice business applications with a web-interface

Asterix is a module designed to build relational database web applications using the core Drupal API as a framework. It is configuration (file) driven. In the DEMO directory are a couple of demonstration configuration files to showcase the functionality.
The best example is the bugtrack.as file. Unfortunately this file is only available in Dutch at this moment. An English version is being worked on.
Although Asterix is a work in progress, it is already in use as the backoffice application for a big Dutch website. My company is aware of contributing this module to the community, but only after security checks by the community can this name eventualy be revealed.
The bugtrack application configuration was created during a 1 hour agile brainstorm session with 3 people. A business analyst, a programmer and a tester.
Please check it out. I welcome every feedback.

Note: There are still json files in the demo directory. These are obsolete and will be removed. Check out the files with the .as extention. These are parsed by the new Asterix Script processor.

Note 2: Please be aware that although i am an experienced PHP/MySql developer and have written multiple Drupal 6 modules, this is my first project I am actually commiting. I am aware of the fact that the project is not completely up to the Drupal standards right now. Please give me the feedback I need to make this project meet every standard you can think of! ;-)

Compatibility

- Drupal 6
- MySql 5 >
- PHP 5 >

Queries generated should be postgress compatible but this is not tested yet

Project page:

http://drupal.org/sandbox/wimtol/1249174

Git

git clone --branch master wimtol@git.drupal.org:sandbox/wimtol/1249174.git asterix

More to come

Already built but not yet available:

  • asterix_tree: View all objects in the datastore as a tree
  • asterix_deploy: Push configurations to remote servers
  • asterix_code: Event handling using PHP from the webinterface. Automaticaly pushed by asterix_deploy
  • asterix_export: API module for streaming asterix data to the client. Two support modules available for creating CSV and SDF files
CommentFileSizeAuthor
#1 coder-result.txt16.45 KBklausi

Comments

klausi’s picture

Status: Needs review » Needs work
StatusFileSize
new16.45 KB

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

  • Run coder to check your style, some issues were found (please check the Drupal coding standards). See attachment.
  • README.txt is missing, see the guidelines for in-project documentation.
  • Remove "version" from the info file, it will be added by drupal.org packaging automatically.
  • ./designtime/asterix_script.inc: comment lines should break at 80 characters, see http://drupal.org/node/1354#general
      // If filename is NULL we need to close the fiel and reset the filhandle for the next file
    
  • ./shared/asterix_access.inc: comment lines should break at 80 characters, see http://drupal.org/node/1354#general
      // If we have a delete request (or copy!)), there is only a main_id, so let's get the tablename
      ... many other places ...
    
  • ./shared/asterix_profiler.inc: all functions should have doxygen doc blocks, see http://drupal.org/node/1354#functions
    
    function asterix_profiler( $name = '', $op = 'start' ) {
    
  • ./asterix.install: all functions should have doxygen doc blocks, see http://drupal.org/node/1354#functions
     
    function asterix_schema() {
    --
    
    function asterix_install() {
    
    ... many other places ...
    
  • There should be a space before and after operators like ==, ===, && and ||. See http://drupal.org/node/318#controlstruct
    asterix_events/asterix_event_element_save.inc:24:    if ($field_config['type']=='date') {
    asterix_events/asterix_event_element_save.inc:29:    elseif ($field_config['type']=='checkboxes') {
    asterix_events/asterix_event_element_save.inc:34:    elseif ($field_config['type']=='select' and $field_config['multiple']) {
    asterix_events/asterix_event_element_save.inc:38:    elseif ($field_config['type']=='file') {
    runtime/asterix_runtime_actions.inc:67:    //if($child_id==$main_id or $child_id==$new_main_id) continue;
    
  • There should be no space after the opening "(" of a control structure, see http://drupal.org/node/318#controlstruct
    asterix_events/asterix_event_localize.inc:20:  if ( $config['language'] != $language->language ) {
    asterix_events/asterix_event_localize.inc:22:    if ( is_array( $config['tables'] ) ) {
    asterix_events/asterix_event_localize.inc:23:      foreach ( $config['tables'] as $table_name => &$table_config ) {
    ... many other places ...
    
  • There should be no space after the opening "(" of an array, see http://drupal.org/node/318#array
    asterix_events/asterix_event_localize.inc:22:    if ( is_array( $config['tables'] ) ) {
    asterix_events/asterix_event_localize.inc:75:  if ( is_array( $config['fields'] ) ) {
    asterix_events/asterix_event_localize.inc:108:    if ( is_array( $config_value ) ) {
    ... many other places ...
    

This automated report was generated with PAReview.sh, your friendly project application review script. Please report any bugs to klausi.

wimtol’s picture

Hi klausi,

Thnx for your time and effort. I'll look into the branching and the coder issues. By the way, have a look at the last code issue. It seems your script is looking at my is_array() function as if it was the array() function. Agree? Or are you just calling coder functionality from your script? Either way. I'll look into it.

Wim

klausi’s picture

yes, my script also finds in_array() here, but it does not matter as there should be also no space. See http://drupal.org/node/318#functcall

wimtol’s picture

Status: Needs work » Needs review

Hi Klausi,

I ran coder and fixed all of the issues. Updated the info file, created a new branch, added the README.txt file etc. etc.

Right now i'm looking into removing the master branch from git.

Wim

klausi’s picture

Status: Needs review » Needs work

wrong branch name, 6.x-1.x-dev should be 6.x-1.x. I think you cannot remove the master branch currently, you can only empty it. See step 5 in http://drupal.org/node/1127732
My script uses the Drupal 7 version of coder, so it may find more errors than the Drupal 6 version.

Review of the 6.x-1.x-dev branch:

  • Run coder to check your style, some issues were found (please check the Drupal coding standards):
    Severity minor, Drupal Commenting Standards, Internationalization, Drupal Security Checks, Drupal SQL Standards, Drupal Coding Standards
    
    sites/all/modules/pareview_temp/test_candidate/asterix.module:
     +6: [minor] There should be no trailing spaces
     +18: [minor] There should be no trailing spaces
     +19: [minor] Comment should be read "Implements hook_foo()."
     +33: [minor] There should be no trailing spaces
     ... same errors in many other places ...
    
    Status Messages:
     Coder found 1 projects, 23 files, 403 minor warnings, 0 warnings were flagged to be ignored
    
  • ./designtime/asterix_script.inc: comment lines should break at 80 characters, see http://drupal.org/node/1354#general
      // If filename is NULL we need to close the fiel and reset the filhandle for the next file
    
  • ./shared/asterix_access.inc: comment lines should break at 80 characters, see http://drupal.org/node/1354#general
      // If we have a delete request (or copy!)), there is only a main_id, so let's get the tablename
      ... many other palces ...
    
  • Comments should be on a separate line before the code line, see http://drupal.org/node/1354#inline
    ./designtime/asterix_settings.inc:12:  $form[$var_name] = array( //
    ./designtime/asterix_settings.inc:13:    '#type' => 'textfield', //
    ./designtime/asterix_settings.inc:14:    '#title' => t('Location of the configurationfile'), //
    ... many other palces ...
    
  • ./designtime/asterix_settings.inc: all functions should have doxygen doc blocks, see http://drupal.org/node/1354#functions
    
    function asterix_settings_form($form_state) {
    
  • ./shared/asterix_profiler.inc: all functions should have doxygen doc blocks, see http://drupal.org/node/1354#functions
    
    function asterix_profiler($name = '', $op = 'start') {
    
  • ./asterix.install: all functions should have doxygen doc blocks, see http://drupal.org/node/1354#functions
    
    function asterix_install() {
    
  • There should be no space after the opening "(" of an array, see http://drupal.org/node/318#array
    asterix.install:25:      'MainID' => array(  'type' => 'serial', 'size' => 'big', 'unsigned' => TRUE, 'not NULL' => TRUE, ),
    asterix.install:28:      'TypeID'    => array( 'type' => 'int', 'size' => 'normal', 'unsigned' => TRUE, 'not NULL' => TRUE, ),
    asterix.install:29:      'ParentID'  => array( 'type' => 'int', 'size' => 'normal', 'unsigned' => TRUE, 'not NULL' => TRUE, ),
    ... many other palces ...
    

This automated report was generated with PAReview.sh, your friendly project application review script. Please report any bugs to klausi.

wimtol’s picture

Yep. Coder for Drupal 7 is absolutely finding more errors than the 6 version. Minor errors are down to 6 in my case. In your case its still 403 as i can see. Pff.....

I'm going to set up a Dupal 7 sandbox on my local machine for reviewing purposes.

Thnx

wimtol’s picture

Status: Needs work » Needs review

Fixed the branche (again ;-)) but right this time. Ran coder from drupal 7, created a couple of regular expressions for finding trailing spaces and wrong comment lines etc. etc.
So this version should fix all coder issues. Well... keep my fingers crossed.

doitDave’s picture

Status: Needs review » Needs work

Hi,

Automated review (Please keep in mind that this is primarily a high level check that does not replace but, after all, eases the review process. There is no guarantee that no other issues could show up in a more in-depth manual follow-up review.)

Review of the 6.x-1.x branch:

  • Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards):
    
    FILE: ...eb/dp709/sites/all/modules/pareview_temp/test_candidate/asterix.install
    --------------------------------------------------------------------------------
    FOUND 2 ERROR(S) AND 22 WARNING(S) AFFECTING 24 LINE(S)
    --------------------------------------------------------------------------------
      4 | ERROR   | The second line in the file doc comment must be " * @file"
     19 | ERROR   | Multi-line assignments must have the equal sign on the second
        |         | line
     24 | WARNING | Last item of an inline array must not followed by a comma
     26 | WARNING | Last item of an inline array must not followed by a comma
     27 | WARNING | Last item of an inline array must not followed by a comma
     29 | WARNING | Last item of an inline array must not followed by a comma
     30 | WARNING | Last item of an inline array must not followed by a comma
     31 | WARNING | Last item of an inline array must not followed by a comma
     32 | WARNING | Last item of an inline array must not followed by a comma
     34 | WARNING | Last item of an inline array must not followed by a comma
     36 | WARNING | Last item of an inline array must not followed by a comma
     38 | WARNING | Last item of an inline array must not followed by a comma
     41 | WARNING | Last item of an inline array must not followed by a comma
     42 | WARNING | Last item of an inline array must not followed by a comma
     43 | WARNING | Last item of an inline array must not followed by a comma
     46 | WARNING | Last item of an inline array must not followed by a comma
     47 | WARNING | Last item of an inline array must not followed by a comma
     48 | WARNING | Last item of an inline array must not followed by a comma
     49 | WARNING | Last item of an inline array must not followed by a comma
     50 | WARNING | Last item of an inline array must not followed by a comma
     51 | WARNING | Last item of an inline array must not followed by a comma
     52 | WARNING | Last item of an inline array must not followed by a comma
     53 | WARNING | Last item of an inline array must not followed by a comma
     54 | WARNING | Last item of an inline array must not followed by a comma
    --------------------------------------------------------------------------------
    
    
    FILE: ...web/dp709/sites/all/modules/pareview_temp/test_candidate/asterix.module
    --------------------------------------------------------------------------------
    FOUND 11 ERROR(S) AND 1 WARNING(S) AFFECTING 12 LINE(S)
    --------------------------------------------------------------------------------
      11 | ERROR   | "require_once" is a statement not a function; no parentheses
         |         | are required
      12 | ERROR   | "require_once" is a statement not a function; no parentheses
         |         | are required
      13 | ERROR   | "require_once" is a statement not a function; no parentheses
         |         | are required
      14 | ERROR   | "require_once" is a statement not a function; no parentheses
         |         | are required
     235 | ERROR   | Inline control structures are not allowed
     237 | ERROR   | Inline control structures are not allowed
     258 | ERROR   | Inline control structures are not allowed
     300 | ERROR   | Inline control structures are not allowed
     310 | ERROR   | Inline control structures are not allowed
     320 | WARNING | A comma should follow the last multiline array item. Found:
         |         | $type
     362 | ERROR   | Inline control structures are not allowed
     390 | ERROR   | Inline control structures are not allowed
    --------------------------------------------------------------------------------
    
    
    FILE: ...eview_temp/test_candidate/asterix_events/asterix_event_check_config.inc
    --------------------------------------------------------------------------------
    FOUND 9 ERROR(S) AFFECTING 9 LINE(S)
    --------------------------------------------------------------------------------
      24 | ERROR | Space before closing parenthesis of function call prohibited
      71 | ERROR | Inline control structures are not allowed
      80 | ERROR | Inline control structures are not allowed
     104 | ERROR | Space before closing parenthesis of function call prohibited
     107 | ERROR | Inline control structures are not allowed
     109 | ERROR | Inline control structures are not allowed
     118 | ERROR | A cast statement must be followed by a single space
     132 | ERROR | Inline control structures are not allowed
     173 | ERROR | Space before closing parenthesis of function call prohibited
    --------------------------------------------------------------------------------
    
    
    FILE: ...eview_temp/test_candidate/asterix_events/asterix_event_element_edit.inc
    --------------------------------------------------------------------------------
    FOUND 4 ERROR(S) AND 2 WARNING(S) AFFECTING 2 LINE(S)
    --------------------------------------------------------------------------------
     32 | ERROR   | A cast statement must be followed by a single space
     32 | ERROR   | A cast statement must be followed by a single space
     32 | ERROR   | A cast statement must be followed by a single space
     32 | WARNING | Last item of an inline array must not followed by a comma
     42 | ERROR   | A cast statement must be followed by a single space
     42 | WARNING | Silencing errors is discouraged
    --------------------------------------------------------------------------------
    
    
    FILE: ...eview_temp/test_candidate/asterix_events/asterix_event_element_save.inc
    --------------------------------------------------------------------------------
    FOUND 3 ERROR(S) AFFECTING 3 LINE(S)
    --------------------------------------------------------------------------------
      4 | ERROR | The second line in the file doc comment must be " * @file"
     75 | ERROR | An unary opeator statement must not followed by a space
     78 | ERROR | An unary opeator statement must not followed by a space
    --------------------------------------------------------------------------------
    
    
    FILE: ...eview_temp/test_candidate/asterix_events/asterix_event_element_show.inc
    --------------------------------------------------------------------------------
    FOUND 4 ERROR(S) AFFECTING 4 LINE(S)
    --------------------------------------------------------------------------------
     52 | ERROR | Inline control structures are not allowed
     65 | ERROR | Inline control structures are not allowed
     91 | ERROR | Inline control structures are not allowed
     97 | ERROR | Inline control structures are not allowed
    --------------------------------------------------------------------------------
    
    
    FILE: .../pareview_temp/test_candidate/asterix_events/asterix_event_localize.inc
    --------------------------------------------------------------------------------
    FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
    --------------------------------------------------------------------------------
     62 | ERROR | A cast statement must be followed by a single space
    --------------------------------------------------------------------------------
    
    
    FILE: .../all/modules/pareview_temp/test_candidate/designtime/asterix_script.inc
    --------------------------------------------------------------------------------
    FOUND 8 ERROR(S) AFFECTING 8 LINE(S)
    --------------------------------------------------------------------------------
      36 | ERROR | Inline control structures are not allowed
      73 | ERROR | Inline control structures are not allowed
     153 | ERROR | A cast statement must be followed by a single space
     154 | ERROR | Inline control structures are not allowed
     156 | ERROR | A cast statement must be followed by a single space
     171 | ERROR | A cast statement must be followed by a single space
     176 | ERROR | Inline control structures are not allowed
     178 | ERROR | Inline control structures are not allowed
    --------------------------------------------------------------------------------
    
    
    FILE: ...ites/all/modules/pareview_temp/test_candidate/runtime/asterix_entry.inc
    --------------------------------------------------------------------------------
    FOUND 3 ERROR(S) AND 1 WARNING(S) AFFECTING 4 LINE(S)
    --------------------------------------------------------------------------------
      4 | ERROR   | The second line in the file doc comment must be " * @file"
     43 | ERROR   | Inline control structures are not allowed
     55 | WARNING | Silencing errors is discouraged
     99 | ERROR   | Inline control structures are not allowed
    --------------------------------------------------------------------------------
    
    
    FILE: ...odules/pareview_temp/test_candidate/runtime/asterix_runtime_actions.inc
    --------------------------------------------------------------------------------
    FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
    --------------------------------------------------------------------------------
     42 | ERROR | Inline control structures are not allowed
     95 | ERROR | A cast statement must be followed by a single space
    --------------------------------------------------------------------------------
    
    
    FILE: ...l/modules/pareview_temp/test_candidate/runtime/asterix_runtime_edit.inc
    --------------------------------------------------------------------------------
    FOUND 6 ERROR(S) AND 5 WARNING(S) AFFECTING 11 LINE(S)
    --------------------------------------------------------------------------------
      30 | WARNING | Silencing errors is discouraged
      64 | WARNING | Silencing errors is discouraged
      79 | ERROR   | Inline control structures are not allowed
      81 | ERROR   | Inline control structures are not allowed
      96 | ERROR   | Inline control structures are not allowed
     108 | ERROR   | Inline control structures are not allowed
     116 | ERROR   | Inline control structures are not allowed
     132 | ERROR   | Inline control structures are not allowed
     161 | WARNING | Last item of an inline array must not followed by a comma
     162 | WARNING | Last item of an inline array must not followed by a comma
     166 | WARNING | Last item of an inline array must not followed by a comma
    --------------------------------------------------------------------------------
    
    
    FILE: ...l/modules/pareview_temp/test_candidate/runtime/asterix_runtime_list.inc
    --------------------------------------------------------------------------------
    FOUND 17 ERROR(S) AND 6 WARNING(S) AFFECTING 22 LINE(S)
    --------------------------------------------------------------------------------
      27 | WARNING | Silencing errors is discouraged
      29 | ERROR   | Inline control structures are not allowed
      39 | ERROR   | Inline control structures are not allowed
      53 | ERROR   | A cast statement must be followed by a single space
      54 | ERROR   | A cast statement must be followed by a single space
      58 | ERROR   | A cast statement must be followed by a single space
     114 | ERROR   | A cast statement must be followed by a single space
     114 | WARNING | Silencing errors is discouraged
     123 | ERROR   | Inline control structures are not allowed
     126 | ERROR   | Inline control structures are not allowed
     134 | ERROR   | Inline control structures are not allowed
     172 | WARNING | Silencing errors is discouraged
     175 | ERROR   | Inline control structures are not allowed
     178 | ERROR   | Inline control structures are not allowed
     209 | ERROR   | File is being conditionally included; use "include_once"
         |         | instead
     244 | ERROR   | Inline control structures are not allowed
     289 | ERROR   | Inline control structures are not allowed
     298 | WARNING | Silencing errors is discouraged
     317 | ERROR   | Inline control structures are not allowed
     319 | ERROR   | Inline control structures are not allowed
     326 | WARNING | Last item of an inline array must not followed by a comma
     334 | ERROR   | Inline control structures are not allowed
     371 | WARNING | Silencing errors is discouraged
    --------------------------------------------------------------------------------
    
    
    FILE: ...es/pareview_temp/test_candidate/runtime/asterix_runtime_list_search.inc
    --------------------------------------------------------------------------------
    FOUND 2 ERROR(S) AND 1 WARNING(S) AFFECTING 3 LINE(S)
    --------------------------------------------------------------------------------
     38 | WARNING | Last item of an inline array must not followed by a comma
     80 | ERROR   | Inline control structures are not allowed
     82 | ERROR   | Inline control structures are not allowed
    --------------------------------------------------------------------------------
    
    
    FILE: ...ites/all/modules/pareview_temp/test_candidate/shared/asterix_access.inc
    --------------------------------------------------------------------------------
    FOUND 4 ERROR(S) AND 1 WARNING(S) AFFECTING 5 LINE(S)
    --------------------------------------------------------------------------------
      28 | ERROR   | Inline control structures are not allowed
      46 | WARNING | Silencing errors is discouraged
      80 | ERROR   | Inline control structures are not allowed
     109 | ERROR   | Inline control structures are not allowed
     123 | ERROR   | Inline control structures are not allowed
    --------------------------------------------------------------------------------
    
    
    FILE: ...9/sites/all/modules/pareview_temp/test_candidate/shared/asterix_api.inc
    --------------------------------------------------------------------------------
    FOUND 23 ERROR(S) AND 4 WARNING(S) AFFECTING 26 LINE(S)
    --------------------------------------------------------------------------------
       43 | ERROR   | Inline control structures are not allowed
       55 | ERROR   | A cast statement must be followed by a single space
       59 | WARNING | Silencing errors is discouraged
      101 | ERROR   | Inline control structures are not allowed
      185 | WARNING | Silencing errors is discouraged
      210 | ERROR   | Inline control structures are not allowed
      219 | ERROR   | A cast statement must be followed by a single space
      243 | ERROR   | A cast statement must be followed by a single space
      243 | WARNING | Silencing errors is discouraged
      277 | ERROR   | Inline control structures are not allowed
      304 | ERROR   | Inline control structures are not allowed
      376 | WARNING | Last item of an inline array must not followed by a comma
      382 | ERROR   | Inline control structures are not allowed
      430 | ERROR   | Inline control structures are not allowed
      493 | ERROR   | Inline control structures are not allowed
      600 | ERROR   | File is being conditionally included; use "include_once"
          |         | instead
      689 | ERROR   | Inline control structures are not allowed
      699 | ERROR   | Inline control structures are not allowed
      721 | ERROR   | Inline control structures are not allowed
      756 | ERROR   | Inline control structures are not allowed
      790 | ERROR   | A cast statement must be followed by a single space
      848 | ERROR   | A cast statement must be followed by a single space
      864 | ERROR   | Inline control structures are not allowed
      964 | ERROR   | Inline control structures are not allowed
     1054 | ERROR   | Inline control structures are not allowed
     1056 | ERROR   | Inline control structures are not allowed
     1074 | ERROR   | A cast statement must be followed by a single space
    --------------------------------------------------------------------------------
    
    
    FILE: ...es/all/modules/pareview_temp/test_candidate/shared/asterix_profiler.inc
    --------------------------------------------------------------------------------
    FOUND 4 ERROR(S) AFFECTING 4 LINE(S)
    --------------------------------------------------------------------------------
     22 | ERROR | Inline control structures are not allowed
     27 | ERROR | A cast statement must be followed by a single space
     32 | ERROR | A cast statement must be followed by a single space
     33 | ERROR | A cast statement must be followed by a single space
    --------------------------------------------------------------------------------
    
  • Comments should be on a separate line before the code line, see http://drupal.org/node/1354#inline
    ./shared/asterix_api.inc:679:  $where = '1'; // Default return value always shows all records
    ./shared/asterix_api.inc:709:    $where_clauses = array('0'); // 0 defaults to NO ACCESS
    ./shared/asterix_access.inc:55:    } // END Foreach $tables
    ./shared/asterix_access.inc:56:  } // End Foreach Configurations
    ./asterix.module:299:  asterix_profiler(__function__, 'start'); // No User access!
    ./asterix.module:301:    return; // Return all messages and reset the message list
    ./asterix.module:311:    return; // initialize
    ./templates/asterix_list_main_display.tpl.php:32:<?php // dpm(get_defined_vars()); ?>
    ./runtime/asterix_runtime_list.inc:135:      $head['sort'] = 'asc'; // default ascending sort
    ./runtime/asterix_runtime_list.inc:137:      $head['sort'] = 'desc'; // default ascending sort
    ./runtime/asterix_runtime_list.inc:283:  $return = ''; // default return value
    
  • All text files should end in a single newline (\n). See http://drupal.org/node/318#indenting
    ./designtime/asterix_settings.inc ./designtime/asterix_script.inc ./shared/asterix_api.inc ./shared/asterix_profiler.inc ./shared/asterix_access.inc ./asterix.install ./asterix_events/asterix_event_check_config.inc ./asterix_events/asterix_event_element_edit.inc ./asterix_events/asterix_event_element_save.inc ./asterix_events/asterix_event_localize.inc ./asterix_events/asterix_event_element_show.inc ./README.txt ./asterix.module ./templates/asterix_start_page_element.tpl.php ./templates/asterix_trail.tpl.php ./templates/asterix_button.tpl.php ./templates/asterix_list_main_display.tpl.php ./templates/asterix_start_page.tpl.php ./templates/asterix_buttonbar.tpl.php ./runtime/asterix_runtime_edit.inc ./runtime/asterix_runtime_actions.inc ./runtime/asterix_entry.inc ./runtime/asterix_runtime_list.inc ./runtime/asterix_runtime_list_search.inc ./css/asterix.css ./asterix.info
    

This automated report was generated with PAReview.sh, your friendly project application review script. Go and review some other project applications, so we can get back to yours sooner.

Manual additions:

  • There are still files in your master branch. You should replace them as described in http://drupal.org/node/1127732 at step 5.
  • You do not need a 6.x-1.x-dev branch. Dev snapshots will be created automatically once you turn it into a full project. Also, releases will be created based on tags later. So just drop it.

hth, dave

wimtol’s picture

Status: Needs work » Needs review

Fixed all coding style issues and cleaned out the master branch. Turned out I already did it but forgot to push it, mww.... Also removed the 6.x-1.x-dev branch.

Thnx to dave

patrickd’s picture

Status: Needs review » Needs work
patrickd’s picture

Status: Needs work » Needs review

Switched back to needs review, so in-depth reviews won't be blocked by coding standart issues.

wimtol’s picture

I bow to The .....

Thnx patrickd, for pointing me to the (your?) website with the automated pareview!!

I was struggling for a while trying to get pareview working (I'm running 99% of my time on windows) and codesniffer... Tried Eclipse with the plugins for codesniffer, no luck......

So I'm more than pleased with the review site.

Thnx again.... i'll be back soon with 0 coding errors ;-)

By the way, busy with the documentation website right now, maybe you could take a look at
https://sites.google.com/site/asterixrad/

Just remember... work in progress.

wimtol’s picture

Fixed all coding issues.

Great thanx to patrickd, again, for making it easier to run PAReview.sh by way of his web interface!! Great work.

wimtol’s picture

Status: Needs review » Active

Stub

wimtol’s picture

Status: Active » Needs review

Anybody .........

Is there anybody that would be so kind to take a look at this module so that i can go on with the project?

If you need anything, any help, any information or what so ever, please feel free to ask. No problem.

patrickd’s picture

Sorry for the delay but as there was a flood of new application over the holidays this will take some time.
too many applicatants and too few reviewers (please think about helping us by reviewing others)
As it's best practice to review issue with the oldest "last update" state first your bumping is quite contraproductive

rudiedirkx’s picture

I have just one tiny remark: please don't commit files like Thumbs.db. It's alright if you have a .gitignore in your project folder, but even better if you have it somewhere locally as a global gitignore, so you don't commit a .gitignore.

Your commit messages, README and CHANGELOG are excellent =)

And a question: why is it a Drupal module? Does it add something to Drupal websites or is it just an unrelated tool 'written in Drupal'?

wimtol’s picture

Hi,

Thnx for the tips.

Why a drupal module? Good question.
1. I love drupal.
2. The Drupal API is very powerfull
3. A module like this is missing in my opinion

Most people use Drupal as a CMS. Me to. But at my company almost every website we build is accompanied by a 'backoffice', a database application. And that is not realy the strength of Drupal. But with Asterix it is! We use it all the time.

But..... it could be that it's just not for you. If you're just building websites for anonymous users it probably isn't.

Maybe I should make a screencast explaining what can be done and 'WHY' you could use Asterix ? Mwwwww...... something to think about.

rudiedirkx’s picture

I've seem 10 minutes of your google sites screencast. Looks nice. And fast. I still don't get why it's a drupal module though. Drupal itself provides all of this and muck more: CCK (D6)/Fields (D7), Views, Views bulk operations, Rules etc.

You could have used several config file formats: json, yaml, xml, ini, php. Why a proprietary format? It makes the module less open and extendable.

Have you worked with D7? Fields make it amazing. Much better, easier and more powerful than CCK AND it's extendable by other modules (i.e. the Timefield or SI modules).

You've put a lot of effort into making a framework... Drupal already is that framework... It's good practice, but is it useful for other people? I wouldn't use it. I'd use Fields and Views etc.

Not to bash :) but I don't see the point...

rudiedirkx’s picture

What would be very useful is a module that sets up node types and their dependencies from 1 config file. Although, that's almost what Features does. You should check out Features too =) In D7 ofcourse.

(Features makes a module from existing settings so you can export them combined to another site (or save them as backup).)

wimtol’s picture

Hi Rudy,

I absulutely get your point. Don't reinvent the weel. Completely agree with that. Im my opinion I don't. You're obviously in doubt ;-)

But... i'm working on the Drpal 7 variant of Asterix. Leaner, meaner, more extensible. And I'm absolutely looking at integrating it with the Fields API.

More than that even... integration with nodes/views/cck etc.etc. But...... even than....... there's the problem of performance. The node system just isn't/wasn't designed for loads of data.

About the 'language'. The script is tailormade for Asterix, Yes it is. I examined INI (Multiple levels are a problem), JSON (readibility and parsing is a pain) YAML (I like the indentation but for the rest ..)

But in Drupal style, there is a hook (event) for loading the config. You can easily build your own module for reading Yaml, ini and/or json files. By the way, you can also define the config is a plain old multi-level array.

Grtz,
Wim

Sorry for the delay. Busy@work

prashantgoel’s picture

Status: Needs review » Needs work
wimtol’s picture

#$%%@@# Pffffff...... fixed all coding errors december 15 2011......... new version of codesniffer

Ok, I"ll fix it again......

But in the meantime.... anybody interested in having a serious look?

Grtz

mitchell’s picture

Interesting project. Thanks for contributing!

* your demos look very interesting. they remind me of Patterns
* -1 on the name. this isn't telephony related, and doesn't tell anything about the project. from the looks of it though, it you're not doing any major integration with drupal core, so it's understandable that namespacing this project would be difficult.
* I wouldn't call these api introductions a red flag, but it's just outside the mainstream, so there'd be an uphill battle in adoption.
* please move your docs onto d.o. that would help with review.
* could you please describe what influenced your architecture designs?
* how does this compare to drupal core's APIs?

klausi’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.