ComScore

Hi victor.galguera,

The code currently in Git is incomplete. Specifically, comscore.info needs more information, and comscore.install and comscore.test are both empty and should be removed or filled. You should also follow the instructions for creating a D7-specific branch in Git, as you'll need that to create releases when this is approved.

Please set this back to "needs review" when these steps are complete.

• Project page is too short, please add the purpose of the module and how it works.
• git release branch missing, see http://drupal.org/node/1015226
• README.txt is missing
• "Implements hook_help." should be "Implements hook_help()."
• comscore_help(): no need to use a switch() here if you just have one case. Use an "if" instead.
• curpageurl(): all functions in your module need to be prefixed with your module name to avoid name clashes.
• curpageurl(): indentation errors, please run coder to check your code style http://drupal.org/project/coder
• module file: there are a lot of empty lines at end, please remove them. One should be enough.

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• Run coder to check your style, some issues were found (please check the Drupal coding standards):
  

  Severity minor, Drupal Commenting Standards, Internationalization, Drupal Security Checks, Drupal SQL Standards, Drupal Coding Standards
  
  sites/all/modules/pareview_temp/test_candidate/comscore.module:
   +12: [minor] Missing period
   +21: [minor] There should be no trailing spaces
   +22: [minor] There should be no trailing spaces
   +23: [minor] There should be no trailing spaces
   +25: [minor] There should be no trailing spaces
   +26: [minor] There should be no trailing spaces
   +28: [minor] There should be no trailing spaces
   +40: [minor] There should be no trailing spaces
   +41: [minor] There should be no trailing spaces
   +62: [minor] There should be no trailing spaces
   +73: [minor] There should be no trailing spaces
   +83: [minor] There should be no trailing spaces
   +88: [minor] There should be no trailing spaces
   +101: [minor] There should be no trailing spaces
   +117: [minor] There should be no trailing spaces
   +121: [minor] There should be no trailing spaces
   +129: [minor] There should be no trailing spaces
   +131: [minor] There should be no trailing spaces
   +133: [minor] There should be no trailing spaces
   +135: [minor] There should be no trailing spaces
   +136: [minor] There should be no trailing spaces
   +138: [minor] There should be no trailing spaces
  
  Status Messages:
   Coder found 1 projects, 2 files, 22 minor warnings, 0 warnings were flagged to be ignored
  

• ./comscore.module: The description for the @return documentation is either missing or not formatted correctly. See http://drupal.org/node/1354#functions
  

  27- * A string where that contains the js file path  for tracking of the site.
  

• Assignments should hava a space before and after the operator, see http://drupal.org/node/318#operators
  

  ./comscore.module:44:  $pageurl="";
  

This automated report was generated with PAReview.sh, your friendly project application review script. Please report any bugs to klausi.

• Please take a moment to make your project page follow tips for a great project page.
• "Implements hook_help()": there should be a "." at the end, that was the coder error.
• comscore_curpageurl(): indentation errors, the body of the if statement should be indented 2 spaces. See http://drupal.org/node/318#controlstruct . Also the rest of the statements in this function don't seem to be on the coorect indentation level.
• comscore_curpageurl(): the comment says "Custom cURL function.", but there is no cURL call involved?
• comscore_curpageurl(): why do you even need that function? why does something like url($_GET['q'], array('absolute' => TRUE)) not work?
• comscore_menu(): you should not rely on the "access administration pages" permissions, better provide your own permission.

Hi,

changes done

Just to understand, but are you sure this also means issue #1 in klausi's post? This is really not meant to harass you, but if you just take a look at your project page from a user's perspective, would you decide to try out this module? Honestly, I personally have never ever heard of ComScore, but I may be the famous exception. If so, please don't mind and let me know.

Also, your master branch still contains files while it should be empty to avoid confusion.

@victor.galguera has been contacted to ask if the application is abandoned.

After ten weeks with a status of needs work: the applicant may be contacted by a reviewer to determine whether the application was indeed abandoned. The action taken by the reviewer should be documented in the project application issue.

http://drupal.org/node/894256

The application has been closed. If you would like to reopen it, you are free to do so.
See http://drupal.org/node/894256#abandonedtwoweekscontact