The CVS info being sent to the test clients for contrib modules is incorrect. See http://qa.drupal.org/pifr/test/23146:
Repository checkout: failed to checkout from [:pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal-contrib/modules/xmlsitemap/].
I think it should be sending: :pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal-contrib/contributions/modules/xmlsitemap/
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 666392-pift-followup-D6.patch | 1.71 KB | dave reid |
| #10 | 666392-pift-followup-D6.patch | 1.7 KB | dave reid |
| #3 | 666392-pift-cvs-modules-D6.patch | 3.55 KB | dave reid |
Comments
Comment #1
dave reidFYI #666258: Testing PIFR on 7.x-2.x branch is the empty patch for testing I put in XML sitemap 7.x-2.x.
Comment #2
boombatower commentedThis is something on d.o side. Either PIFT issue or something odd in d.o configuration based on how pift queries the information.
Comment #3
dave reidDiscovered the problem is that all projects not Drupal core need the 'modules' information from the CVS repository settings (in contribs case, its the /contributions path). Patch that uses the modules information for non-core projects. Also fixes a few things in the tests, but as boombatower said on IRC they're expected to be broken right now. Just matched some things up to how they actually are on drupal.org with the test data.
Comment #4
dave reidTested out pift_cron_queue_batch_build_projects locally with 'duplicate' projects for core and XML sitemap contrib. This is the data that returned:
So everything looks good I think.
Comment #5
boombatower commentedCommitted. Thanks!
Comment #6
boombatower commentedComment #7
boombatower commentedComment #8
boombatower commentedComment #9
damien tournoud commentedDeployed!
Comment #10
dave reidFollow-up un-break things patch.
Comment #11
dave reidThis version adds an rtrim([cvsurl], '/'). Either this or #10 should work.
Comment #12
boombatower commentedCommitted.
Comment #13
dave reidYeah, sorry about that. Marking back for deployment of #11.
Comment #14
damien tournoud commentedDeployed. That was not fun, but thanks for the fix.