The CVS info being sent to the test clients for contrib modules is incorrect. See http://qa.drupal.org/pifr/test/23146:

Repository checkout: failed to checkout from [:pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal-contrib/modules/xmlsitemap/].

I think it should be sending: :pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal-contrib/contributions/modules/xmlsitemap/

Comments

dave reid’s picture

FYI #666258: Testing PIFR on 7.x-2.x branch is the empty patch for testing I put in XML sitemap 7.x-2.x.

boombatower’s picture

Project: Project Issue File Review » Project issue file test

This is something on d.o side. Either PIFT issue or something odd in d.o configuration based on how pift queries the information.

dave reid’s picture

Status: Active » Needs review
StatusFileSize
new3.55 KB

Discovered the problem is that all projects not Drupal core need the 'modules' information from the CVS repository settings (in contribs case, its the /contributions path). Patch that uses the modules information for non-core projects. Also fixes a few things in the tests, but as boombatower said on IRC they're expected to be broken right now. Just matched some things up to how they actually are on drupal.org with the test data.

dave reid’s picture

Tested out pift_cron_queue_batch_build_projects locally with 'duplicate' projects for core and XML sitemap contrib. This is the data that returned:

define('PIFT_PID', 29);

array(
  2 => 
  array (
    'client_identifier' => '29',
    'name' => 'Drupal',
    'repository_type' => 'cvs',
    'repository_url' => ':pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal/drupal/',
    'link' => 'http://mysql.drupal6dev.local/content/drupal',
  ),
  3 => 
  array (
    'client_identifier' => '30',
    'name' => 'XML sitemap',
    'repository_type' => 'cvs',
    'repository_url' => ':pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal-contrib/contributions/modules/xmlsitemap/',
    'link' => 'http://mysql.drupal6dev.local/content/xml-sitemap',
  ),
);

So everything looks good I think.

boombatower’s picture

Status: Needs review » Fixed

Committed. Thanks!

boombatower’s picture

Issue tags: +Needs deployment
boombatower’s picture

Status: Fixed » Needs work
boombatower’s picture

Issue tags: -Needs deployment +needs drupal.org deployment
damien tournoud’s picture

Status: Needs work » Fixed
Issue tags: -needs drupal.org deployment

Deployed!

dave reid’s picture

Status: Fixed » Needs review
StatusFileSize
new1.7 KB

Follow-up un-break things patch.

dave reid’s picture

StatusFileSize
new1.71 KB

This version adds an rtrim([cvsurl], '/'). Either this or #10 should work.

boombatower’s picture

Status: Needs review » Fixed

Committed.

dave reid’s picture

Status: Fixed » Needs work
Issue tags: +needs drupal.org deployment

Yeah, sorry about that. Marking back for deployment of #11.

damien tournoud’s picture

Status: Needs work » Fixed
Issue tags: -needs drupal.org deployment

Deployed. That was not fun, but thanks for the fix.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.