Depending on configuration with php -l may interpret XML files that start with <?XML as PHP files and report an error therefore. Tests on patches like #364467: Remove-items followed by update items does not work fail because they contain an XML file.

I'd suggest syntax checking PHP files with

php -d short_open_tag=[0] -l

- would that work?

CommentFileSizeAuthor
#2 pifr_parse_short_tag.patch622 bytesboombatower

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

subscribe. I asked hunmonk where to file the issue and he said file it here. Help us, boombatower! You're our only hope! ;)

boombatower’s picture

boombatower commented
Assigned: Unassigned » boombatower
Status: Active » Fixed
StatusFileSize
new pifr_parse_short_tag.patch622 bytes

Actually it would be:

php -d short_open_tag=0 -l

The [] are just there to indicate it is optional. Tested locally and with 0 it work (also my config setting) and with 1 it returns:

Errors parsing hax.xml

Thus I have created one of the world largest patches!

Due to my computer issues I no longer have a way to login the testing servers..thus I will need hunmonk to help me get this uploaded....plus he is working on stardard setup script...we might just add to that.

alex_b’s picture

alex_b commented

boombatower: thanks for taking care of this so quickly :-) - good times for #364467: Remove-items followed by update items does not work

alex_b’s picture

alex_b commented

I filed a ticket for deployment #366193: Testbed: Deploy syntax checking fix - is that the correct place?

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.