Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.The 'pid' case of the switch statement in project_issue_mailhandler() did not make sense to me. The value is a pid -- project id -- which is the parent node id. But the node_load() call -- which may be redundant -- was using 'title' as the array key.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | issue_mail_lookup.2.patch | 658 bytes | scor |
| issue_mail_lookup.patch | 731 bytes | agentrickard |
Comments
Comment #1
dwwThe mailhandler support is so unloved and broken, I don't think there's any way to test this. Patch looks good on visual inspection, at least. :)
Should this go in before or after #98278: project* namespace bugs in $node lands, or will it not conflict?
Thanks,
-Derek
Comment #2
agentrickardNo conflict. The $node->text transition is handled by the other patch and I don't think line numbers are affected. So either.
Comment #3
dwwCommitted to HEAD, DRUPAL-5--2 and DRUPAL-5. Thanks.
Comment #4
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #5
scor commentedWhy did
$node->$textbecome$node->texthere? I don't see$node->textdefined anywhere in the project* modules.Comment #6
agentrickardOh, heck, maybe that's the problem. I may have read that code wrong. Perhaps the patch is wrong and should stay as
$node->$text.Comment #7
agentrickardMore accrately, the correct line is:
Comment #8
scor commentedright, that's what I figured. this is RTBC
Comment #9
dwwYup, good point. Sorry I missed that in the previous review. As I wrote above, this code is completely unloved and almost certainly broken, so I couldn't test then or now, but looking at the surrounding code, this seems right. Committed to HEAD and DRUPAL-5--2. Thanks, all.
Comment #10
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.