Closed (fixed)
Project:
Profile 2
Version:
7.x-1.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
21 Feb 2018 at 14:26 UTC
Updated:
31 Mar 2018 at 15:29 UTC
Jump to comment: Most recent
Comments
Comment #2
joachim commentedThat's great!
Could you give links to a few patches you've posted, ideally on this project?
Comment #3
rickj commentedHI joachim
There's a list of commits I'm credited on in my profile: /user/3371606/track/code. I'm a maintainer on the book_helper module, and I've contributed a module "image_nivo_slider" (based heavily on media_nivo_slider).
For profile2 I raised issue 2845725, with patch. I raised a bug in issue 2683917 but another contributor beat me to the patch!
FYI I'm a retired developer with over 30 years experience on commercial projects. I used Drupal to build web sites for a couple of clubs i'm involved in, and I continue to maintain and enhance them - keeps my hand in and brain active :-)
Regards
Comment #4
joachim commentedThat's great, thanks.
(I've done a merciless review of your patch :) )
Can you contact @Spleshka too please, if you haven't done so already?
Comment #5
rickj commentedI've PM'd @Spleshka, but no response yet.
Thanks for the review. I've gone through it again and come up with a much better solution, see the issue thread.
Comment #6
joachim commentedTry twitter too, d.org emails may be getting chewed up by spam filters.
I'm happy to say that the abandoned project rules should apply here -- if @Spleshka hasn't responded in a couple of weeks, I'll give you the keys :)
Comment #7
spleshkaHi guys, sorry for the delay in response, had incredible busy days!
In general I'm happy to give Rick J access to commit into the module. Before I do this, I'm just curious what's the short-term roadmap when you become a co-maintainer? Thank you.
Comment #8
rickj commentedHi, thanks for the response.
My immediate aim is to produce an up to date release. 7.x.1.3 is very old, and the dev build contains important fixes and appears completely stable. There are also some RTBC patches which I believe should be committed as well, I will review those.
I have a site which relies quite heavily on profile2, and I don't like running on dev+patches indefinitely!
Comment #9
joachim commented> 7.x.1.3 is very old, and the dev build contains important fixes and appears completely stable. There are also some RTBC patches which I believe should be committed as well, I will review those.
I would recommend that you release a 7.x-1.4 first, and then review the RTBCs. As you say, we have cause to believe the -dev is stable, as we can see the usage numbers. Committed patches onto that adds uncertainty. It's best to do things in steps, and release a 1.5 later, once you've made a number of commits.
Apart from that, +1 to this plan!
Comment #10
spleshkaAgree with @joachim, please, release 7.x-1.4 first.
I was about to give @Rick J co-maintainer permissions, but suddently realizes I don't have perms to assign new contributors :) So I have to ask you @joachim to do this.
Anyway, good luck in maintenance and thank you for your future contributions! Reach out to me or @joachim if you'll ever need any help.
Comment #11
rickj commentedThanks guys, yes I was thinking along those lines for a new release.
I'll pick up on this next week, I'm away for a few days the rest of this week.
Comment #12
joachim commentedOk, you are now a co-maintainer! :)
A couple of other things:
- commit message should use the standard Drupal commit message format: https://www.drupal.org/node/52287
- (shameless plug) Try Dorgflow for working with issues and patches. It speeds up the process of applying and committing patches :)
Comment #13
rickj commentedHi Joachim
I was just catching up on this, and tried pushing a new 7.x-1.4 tag for a new release, but got a 403 error:
fatal: unable to access 'https://git.drupal.org/project/profile2.git/': The requested URL returned error: 403
Looks like I don't yet have write access to the repository. Is this something you can fix?
Thanks.
Comment #14
joachim commented> fatal: unable to access 'https://git.drupal.org/project/profile2.git/': The requested URL returned error: 403
Is that a local copy you cloned before you became a maintainer? If so, you'll need to change git's URL for the remote.
Comment #15
rickj commentedAh yes, well spotted. I still had the generic URL rather than my login.
All sorted, I've pushed 7.x-1.4.
Comment #16
joachim commentedExcellent!
BTW, another useful tool for maintainers: https://www.drupal.org/project/grn