I know 2.x is still in dev but from our talk on IRC it sounded like it might be ok to give it a go. Unfortunately, I didn't think to ask you about upgrading. When I tried it on my dev site, I got a bunch of errors with "user warning: Unknown column 'pmi.uid". I did a search on that and found several closed issues about there not being an upgrade path, yet, from 2008. But my searching isn't pulling up any word on whether there will be an upgrade path. Is this something that is planned before release? If there's not going to be one ever, I'll bite the bullet and see about manually porting the messages now. If there's plans for one, though, I'll just wait until it's ready before I upgrade.

Thanks,

Michelle

CommentFileSizeAuthor
#5 uid_not_found.patch2.55 KBberdir

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Category: feature » support
Status: Active » Fixed

You did run update.php, right? :)

There is a working upgrade path for all modules of this project. You however might be using a module that integrates with Privatemsg (privatemsg_views is not 6.x-2.x compatible, pmgrowl needs to be updated to 6.x-2.x), which is not yet compatible.

If you still have issues after running update.php and disabling/updating these modules, please write down the whole error message :)

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Status: Fixed » Postponed (maintainer needs more info)

Yes, all those errors appeared when I ran update.php. Unfortunately, I had to shut down my computer due to storms last night and lost the text of the error message. IIRC, it said something about pm_filter? Not sure if that's exactly right but I'm fairly sure they all had "filter" in them if that helps any. Sorry for the vagueness. Since I searched on the error message before posting, and all my searching led to issues that were closed due there being no upgrade path, I just assumed that was the problem.

I'm not in a position to rebuild my dev site so I can attempt the upgrade again because I have lots of other in progress changes. Once I get those moved live, I'll grab a fresh copy for my dev and run through the upgrade process again. Setting this NMI until I do that.

Thanks,

Michelle

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Title: Upgrade path from 1.x to 2.x? » Update fails because privatemsg_filter updates run after privatemsg

Confirmed the problem, will look into it soon.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Status: Postponed (maintainer needs more info) » Active

Oh? Well, glad it can be repro'd. I haven't been able to get my dev changes live, yet, so I could reset to test. Setting this active since it sounds like you don't need more info from me at the moment?

Michelle

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new uid_not_found.patch2.55 KB

Ok, please try the attached patch.

Note that it will tell you to run update.php again after the first run finished (which can take a long time if you have many messages, I just tested it with 660k rows in pm_index and it took... a while ;)). That is ok and not a problem.

Starminder’s picture

Starminder commented

subscribe.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

I'm sorry, Berdir, I have not been able to work on my own site again since you made the patch. Just so much going on. :(

Michelle

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Category: support » bug
Status: Needs review » Fixed

No problem. I did my own testing anyway and for me, the patch worked. Since this problem also seemed to occur in 6.x-2.x to 7.x-1.x upgrades, I decided to go ahead and commit it both to 6.x-2.x and the 7.x branches.

Once you find time to return to your own site, feel to re-open this if there are still problems or new issues for something else...

Starminder’s picture

Starminder commented
Status: Fixed » Needs work

First off thanks for checking in, the number of patches out there is maddening.

This time (7x upgrade) I got:
An AJAX HTTP error occurred. HTTP Result Code: 200 Debugging information follows. Path: http://hoslotracer.com/update.php?id=605&op=do StatusText: OK ResponseText: Fatal error: Call to undefined function db_column_exists() in /home/hoslot5/public_html/sites/all/modules/privatemsg/privatemsg_filter/privatemsg_filter.install on line 154

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Fixed

Oh, that happens when you don't test...

Should be all good now!

Starminder’s picture

Starminder commented

OK, got past that, now onto this:

PDOException: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'hoslot5_hosr.pm_block_user' doesn't exist: SELECT recipient FROM {pm_block_user} WHERE author = :author AND recipient IN (:recipients_0) GROUP BY recipient; Array ( [:author] => 1 [:recipients_0] => 206 ) in pm_block_user_privatemsg_block_message() (line 299 of /home/hoslot5/public_html/sites/all/modules/privatemsg/pm_block_user/pm_block_user.module).

I can open a new case if it is unrelated. Thanks Berdir, I appreciate your time!

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

New issue please. Also explain when that error happens (during update or on the actual site, from which version you are upgrading...)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.