CommentFileSizeAuthor
#9 interdiff_8-9.txt3.26 KBheddn
#9 3129724-9.patch6.65 KBheddn
#8 3129724-8.patch3.54 KBheddn
#7 interdiff_6-7.txt3.91 KBp-neyens
#7 private_message_3129724-7.patch18.43 KBp-neyens
#6 private_message_3129724-6.patch14.52 KBadityasingh
#2 private_message-drupal_9_readiness-3129724-2.patch365 bytesunrealauk

Comments

unrealauk created an issue. See original summary.

unrealauk’s picture

unrealauk commented
Assigned: unrealauk » Unassigned
Status: Active » Needs review
StatusFileSize
new private_message-drupal_9_readiness-3129724-2.patch365 bytes
phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented

Does the module works on Drupal 9 before adding this?

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue tags: -Drupal 9 readiness +Drupal 9 compatibility

Fixing outdated tag.

adityasingh’s picture

adityasingh commented
Assigned: Unassigned » adityasingh
adityasingh’s picture

adityasingh commented
Assigned: adityasingh » Unassigned
StatusFileSize
new private_message_3129724-6.patch14.52 KB

Fixed as per Drupal coding standards and add core version requirement.Please review.

p-neyens’s picture

p-neyens commented
StatusFileSize
new private_message_3129724-7.patch18.43 KB
new interdiff_6-7.txt3.91 KB

Some extra fixed for Drupal9.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Category: Feature request » Task
StatusFileSize
new 3129724-8.patch3.54 KB

Please, let's not bundle code standard and D9 compatibility into the same issue. Here's what seems the minimum needed for D9 support. No interdiff.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
StatusFileSize
new 3129724-9.patch6.65 KB
new interdiff_8-9.txt3.26 KB

Added patches to message and message_notify to make them D9 compatible. Then tested this on 9.1. A few tweak needed.

divyesh19’s picture

divyesh19
his/him/he
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Tested patch #9 locally, and was successfully able to install the module on D8.9.1 and D9 with patch applied.
Marking it RTBC!
Thanks!

  • anmolgoyal74 committed 80381d5 on 8.x-2.x authored by heddn 
    Issue #3129724 by heddn, p-neyens, unrealauk, adityasingh: Drupal 9...
anmolgoyal74’s picture

anmolgoyal74 commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

cankanoa’s picture

cankanoa commented

Hello,
Love this module, however I am wondering if/when there will be d9 support added for it?
Thanks in advance!

heddn’s picture

heddn
Primary language English
Location Illinois
commented

The dev branch already does support D9, no?

drupalfan2’s picture

drupalfan2 commented

Yes, the dev branch supports Drupal 9 and it works fine.