Problem/Motivation
As part of making this module ready for Drupal 9, we should add a missing core_version_requirement key to the module info file.
see https://www.drupal.org/node/3070687

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

pavnish created an issue. See original summary.

pavnish’s picture

Assigned: pavnish » Unassigned
Status: Active » Needs review
StatusFileSize
new1.11 KB

Hi,
Could you please review this patch .I think it would be fit for this.
Thanks

kristen pol’s picture

berramou’s picture

StatusFileSize
new1.46 KB

Besides the add of core_version_requirement key there is another error need to be fixed:

$ vendor/mglaman/drupal-check/drupal-check  web/modules/contrib/preview_graphql
 30/30 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ -------------------------------------------------------------
  Line   src/Entity/PreviewGraphQL.php
 ------ -------------------------------------------------------------
  42     Configuration entity must define a `config_export` key. See
         https://www.drupal.org/node/2481909
 ------ -------------------------------------------------------------

Here is a patch with the all fixes, need review!

berramou’s picture

StatusFileSize
new2.21 KB

preview_graphql-3116397-4.patch + add composer.json file

musa.thomas’s picture

push in 2.0.x dev branch need review

berramou’s picture

Thank you @Musa.thomas
you have committed .idea folder too, it shouldn't be i guess https://git.drupalcode.org/project/preview_graphql/-/commit/1227f6ffb1e1...

musa.thomas’s picture

sorry :( @berramou commit and push in 2.0

berramou’s picture

Thanks @Musa.thomas it happens :)