Needs review
Project:
Preview graphql
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
27 Feb 2020 at 10:38 UTC
Updated:
21 Mar 2022 at 20:50 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
pavnish commentedHi,
Could you please review this patch .I think it would be fit for this.
Thanks
Comment #3
kristen polComment #4
berramou commentedBesides the add of core_version_requirement key there is another error need to be fixed:
Here is a patch with the all fixes, need review!
Comment #5
berramou commentedpreview_graphql-3116397-4.patch + add composer.json file
Comment #10
musa.thomaspush in 2.0.x dev branch need review
Comment #11
berramou commentedThank you @Musa.thomas
you have committed .idea folder too, it shouldn't be i guess https://git.drupalcode.org/project/preview_graphql/-/commit/1227f6ffb1e1...
Comment #12
musa.thomassorry :( @berramou commit and push in 2.0
Comment #13
berramou commentedThanks @Musa.thomas it happens :)