Currently, no fields show on the add/edit form.

CommentFileSizeAuthor
#30 Selection_620.png42.69 KBfrancewhoa
#28 pm-note-no_org-2.patch1.18 KBjuliangb
#27 pm-note-no_org.patch2.51 KBjuliangb
#23 storm-note-save-6.patch7.74 KBjuliangb
#20 storm-note-save-5.patch7.74 KBjuliangb
#15 note-add.png36.98 KBfrancewhoa
#17 organization.png25.63 KBfrancewhoa
#16 note-display.png18.86 KBfrancewhoa
#13 storm-note-save-4.patch6.45 KBjuliangb
#11 storm-note-save-3.patch6.44 KBjuliangb
#10 storm-note-save-2.patch4.82 KBjuliangb
#9 storm-note-save.patch4.27 KBjuliangb
#5 storm-note-fields-3.patch7.88 KBjuliangb
#4 storm-note-fields-2.patch7.87 KBjuliangb
#2 storm-note-fields.patch7.78 KBjuliangb

Comments

juliangb’s picture

juliangb commented
Assigned: Unassigned » juliangb

Currently working on this (and also fixes the fact that content type isn't shown in list).

juliangb’s picture

juliangb commented
Status: Active » Needs review
StatusFileSize
new storm-note-fields.patch7.78 KB

Here's a patch that goes some way to fixing this.

Only todo I can think of is that there are some aspects of the tasks dropdown that need migrating, so there is an error on changing the project dropdown (loading new tasks).

esoteric1’s picture

esoteric1 commented

I tried to have a look at this but I get errors and WSOD. Specifically, when I try to access the notes list without having created a note, i get a WSOD. When I access the node add page, there is no task I can assign it to. One thing I noticed is that when I try to create a storm task, I cannot assign it to anyone, the select box is empty. This despite having created an organization, person, team etc... I am wondering if perhaps the bug in storm task may be affecting what is happening in stormnote?

juliangb’s picture

juliangb commented
StatusFileSize
new storm-note-fields-2.patch7.87 KB

Reroll of patch, and decided to tackle changes required in stormtask in a separate patch.

juliangb’s picture

juliangb commented
StatusFileSize
new storm-note-fields-3.patch7.88 KB

Patch comments out another call to stormtask.

juliangb’s picture

juliangb commented
Status: Needs review » Fixed

Pushed this into git.

brayo4’s picture

brayo4 commented

When trying to add a note, i get this :

Recoverable fatal error: Argument 2 passed to db_query() must be an array, string given, called in xxxxx/sites/all/modules/storm/stormnote/stormnote.module on line 419 and defined in db_query() (line 2313 of xxxxx/includes/database/database.inc).

juliangb’s picture

juliangb commented
Status: Fixed » Active

Need to work on this bit a bit more...

juliangb’s picture

juliangb commented
Status: Active » Needs review
StatusFileSize
new storm-note-save.patch4.27 KB

Patch to port the database queries on saving.

juliangb’s picture

juliangb commented
StatusFileSize
new storm-note-save-2.patch4.82 KB

Updated patch porting a few other bits.

juliangb’s picture

juliangb commented
StatusFileSize
new storm-note-save-3.patch6.44 KB

Updated patch - also fixes up some of the functionality on insert/view.

brayo4’s picture

brayo4 commented

thx

juliangb’s picture

juliangb commented
StatusFileSize
new storm-note-save-4.patch6.45 KB

Attached patch now shows without errors.

Still having trouble with the node view - the hooks have changed meaning that the way that we previously did this in Storm doesn't work anymore.

Currently this shows without triggering the view theme function, and hence doesn't show the Storm fields.

Any ideas?

kfritsche’s picture

kfritsche
Primary language German
Location 🇩🇪🇪🇺
commented

What has changed there?
After the documentation of hook_view it does the same, as the hook_view in D6.
The problem I think is in the theme function itself. In D7 the default form type is markup and then the '#value' has to be changed into '#markup'.

francewhoa’s picture

francewhoa
he/him
Primary language French
Location Sept-Îles, Québec, 🇨🇦
commented
StatusFileSize
new note-add.png36.98 KB

Add Storm Note returns error. Steps to reproduce:
1. Go to /storm#overlay=node/add/stormnote
2. Drupal returns the following error message. Find attached screenshot "note-add.png" to clarify.

Notice: Undefined property: stdClass::$organization_nid in stormnote_form() (line 297 of [***]/sites/all/modules/storm/stormnote/stormnote.module).
Notice: Undefined property: stdClass::$organization_nid in stormnote_form() (line 306 of [***]/sites/all/modules/storm/stormnote/stormnote.module).

Using
* Patch in comment 13
* Fresh Drupal 7.18
* Storm 7.x-1.x-dev 2012-Dec-24
* Views 7.x-3.5
* CTool 7.x-1.2

francewhoa’s picture

francewhoa
he/him
Primary language French
Location Sept-Îles, Québec, 🇨🇦
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new note-display.png18.86 KB

Notes fields are not display. Steps to reproduce:
1. Go to /storm/notes
2. The node title is display but all other fields are not display. Find attached screenshot "note-display.png" to clarify.

Using same as comment 15

francewhoa’s picture

francewhoa
he/him
Primary language French
Location Sept-Îles, Québec, 🇨🇦
commented
StatusFileSize
new organization.png25.63 KB

"Organization" field is not populated. Steps to reproduce:
1. Go to /storm#overlay=node/add/stormnote
2. Under "Organization" click on "Select". Organization(s) are not display. Find attached screenshot "organization.png" to clarify.

Using same as comment 15

juliangb’s picture

juliangb commented
Status: Reviewed & tested by the community » Needs work

Thanks for testing!

Marking this "needs work".

francewhoa’s picture

francewhoa
he/him
Primary language French
Location Sept-Îles, Québec, 🇨🇦
commented

Thanks juliangb :) I forgot, I should have set to "needs work"

juliangb’s picture

juliangb commented
Status: Needs work » Needs review
StatusFileSize
new storm-note-save-5.patch7.74 KB

The attached patch should *fingers crossed* fix the errors viewing the note.

The organization_nid error that you're seeing is, I think, because you don't have any organizations in your test installation - I'll test the latest changes and then make sure that doesn't error.

juliangb’s picture

juliangb commented

And @Francewhoa - to clarify, in #17, had you created an organization before this test?

Status: Needs review » Needs work

The last submitted patch, storm-note-save-5.patch, failed testing.

juliangb’s picture

juliangb commented
Status: Needs work » Needs review
StatusFileSize
new storm-note-save-6.patch7.74 KB

Fixed a stray bracket.

juliangb’s picture

juliangb commented
Status: Needs review » Active

I've committed #23 - I know there are a couple of bugs remaining (such as the $organization_nid warnings) but it will be easiest to work these out with the main patch committed.

francewhoa’s picture

francewhoa
he/him
Primary language French
Location Sept-Îles, Québec, 🇨🇦
commented

And @Francewhoa - to clarify, in #17, had you created an organization before this test?

juliangb, thx for asking. Yup I created one organization before this test.

juliangb’s picture

juliangb commented
Project: Storm » Drupal PM (Project Management)
Component: Storm Notes » Code

Moving to pm.

juliangb’s picture

juliangb commented
Status: Active » Needs review
StatusFileSize
new pm-note-no_org.patch2.51 KB

Attached patch fixes the last bug in this I think (organization_nid errors).

juliangb’s picture

juliangb commented
StatusFileSize
new pm-note-no_org-2.patch1.18 KB

Redo patch.

juliangb’s picture

juliangb commented
Status: Needs review » Fixed

Committed.

francewhoa’s picture

francewhoa
he/him
Primary language French
Location Sept-Îles, Québec, 🇨🇦
commented
StatusFileSize
new Selection_620.png42.69 KB

juliangb, thanks :) Confirming patch in #28 works.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 41b4bdc on 7.x-1.x, 7.x-2.x by juliangb: 
    Issue #1849016 by juliangb: Fix notes form fields.