php drupal-check.phar modules/contrib/plupload/
 7/7 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ----------------------------------------------------- 
  Line   plupload.module                                      
 ------ ----------------------------------------------------- 
  17     Call to deprecated function file_upload_max_size().  
 ------ ----------------------------------------------------- 

 ------ ------------------------------------------------------- 
  Line   plupload_test/src/PluploadTestForm.php                 
 ------ ------------------------------------------------------- 
  58     Call to deprecated function file_prepare_directory().  
  67     Call to deprecated function file_unmanaged_move().     
  74     Call to deprecated function drupal_set_message().      
 ------ ------------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Element/PlUploadFile.php                       
 ------ --------------------------------------------------- 
  110    Call to deprecated function drupal_basename().     
  120    Call to deprecated function drupal_set_message().  
  268    Call to deprecated function entity_create().       
  272    Call to deprecated function drupal_basename().     
 ------ --------------------------------------------------- 

 ------ ------------------------------------------------------- 
  Line   src/UploadController.php                               
 ------ ------------------------------------------------------- 
  93     Call to deprecated function file_prepare_directory().  
  172    Call to deprecated function drupal_unlink().           
 ------ ------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 10 errors
CommentFileSizeAuthor
#6 3093844-6.patch8.4 KBstijncr
#4 plupload-deprecation-report.png24.3 KBneslee canil pinto
#3 3093844-3.patch8.22 KBlisa.rae
#2 deprecated-3093844-2.patch6.28 KBsergiu stici

Comments

Sergiu Stici created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
StatusFileSize
new deprecated-3093844-2.patch6.28 KB

Here's the patch, please review.

lisa.rae’s picture

lisa.rae commented
Issue tags: +Drupal 9 compatibility
StatusFileSize
new 3093844-3.patch8.22 KB

Rerolling patch for additional deprecations with Drupal 8.8.

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new plupload-deprecation-report.png24.3 KB

#3 removes all the deprecation and makes drupal 9 compatiable. Attached Screeshot

budalokko’s picture

budalokko commented

Great work !! But module does not work due to following issues:

1. UploadController: There's a case typo around htaccessWriter class property.
2. PlUploadFile: $this->loadStreamWrapper() is used in a static method.

Are you willing to fix them?

Thank you !!

stijncr’s picture

stijncr commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3093844-6.patch8.4 KB

Great work!!

Had the same issues when installing this module in Drupal 9. Made modifications to the patch, and this should work now.

Please review

vensires’s picture

vensires
Location Greece
commented
Parent issue: » #3130920: Drupal 9 Compatibility
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me!
Thanks.

  • paulocs committed 7089b38 on 8.x-1.x authored by stijncr 
    Issue #3093844 by Sergiu Stici, stijncr, lhridley, Neslee Canil Pinto,...
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Reviewed & tested by the community » Fixed
neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented

+1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.