Hi,
if I use Quick-mod tools from the dropdown list I get an error:

General Error
No mode specified.

Please notify the board administrator or webmaster: email

I don't tried it before with previous module versions, so I don't know if it's only broken in alpha3 or in previous ones too.
It fails suddenly on:
Lock topic
Move topic
etc..

Split topic bring you to moderato control panel and if you try to split it does nothing without error messages..

Ty

Comments

vb’s picture

vb commented

Fixed in alpha4, but need testing.

subcomandante’s picture

subcomandante commented

I tested this issue and now it works better but not completely, infact now I am able to see phpBB confirmation request if I select e.g. Lock Topic, but the page shows:
http://sitename/phpbbforum/mcp.php?f=2&t=1&quickmod=1&redirect=http://si...phpBB3/viewtopic.php?f=2&t=1&start=0&sid=USERSID
and if I click on "Yes" it go to:
http://sitename/phpbbforumq=drupaldir/index.php&q=phpbbforum/mcp.php&f=2&t=1&quickmod=1&redirect=http://sitename/phpBB3/viewtopic.php?f=2&t=1&start=0&confirm_key=KEY
and it does nothing, the forum still locked/unlocked like previous state.

vb’s picture

vb commented

I cannot reproduce this issue. All work, and I did not see urls like these.
Did you replace all the new files and remove old ones?
/include must be in one place inside all/sites/modules/phpbbforum/ or inside/phpBB3/
(check settings paths, they can point to different locations)
Another thing is in drupal settings.php and phpBB3
Server settings Server URL settings Domain name:
The domain name this board runs from (for example: www.example.com).

base urls must be both with or without www.
Domain name: www.example.com
$base_url = 'http://www.example.com';
or
Domain name: example.com
$base_url = 'http://example.com';

subcomandante’s picture

subcomandante commented

Hi vb,
I've done a fresh install on a dedicated virtual server to help better on this project.

About this issue it seems related to phpBB3 folder symbolic linked in drupal folder.

Dunno if you want to try this out but if you have:
phpBB3
www
phpBB3 -> ../phpBB3

it seems to broke quick-mod tools.

Cheers

vb’s picture

vb commented

in file phpbbforum.pages.inc
function _phpbbforum_replace_urls($output)

uncomment line 441

//$str = array('../', 'www/index.php?'. $q_phpbbforum, '/index.php?'. $q_phpbbforum, 'www/index.php');

I have already wrote the bugfix of your issue but could not test.
Please test and if needed adjust strings which is deleted from wrong generated urls by phpBB running inside.

subcomandante’s picture

subcomandante commented

little progress:

also with alpha5, if you have the forum folder linked from outside the drupal folder quick-mod tools doesn't work.
I tried something with the code and it seems _phpbbforum_replace_urls($output) function is not called when in symlink...

afraid I can't help more now on this..

EDIT:
a little more track on this:
when in symlinked folder, the phpbbforum_redirect($url) function ( which calls _phpbbforum_replace_urls function ) in phpbb_api_hooks.php seems not called...

vb’s picture

vb commented

I did not test and did not planned with phpBB symlinked.
Can't you test with normal phpBB installation under Drupal?

subcomandante’s picture

subcomandante commented

If I move the folder inside drupal folder quick-mod tools works ok.

it does not work only if symlinked..

subcomandante’s picture

subcomandante commented

I start a new ticket for this, just to keep track: #409192: forum folder symlinked does not work properly

subcomandante’s picture

subcomandante commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.