Problem/Motivation

Follow up from https://www.drupal.org/project/photoswipe/issues/3392976, Xss::filter on the caption within photoswipe_dynamic_caption_get_caption is stripping paragraph tags from our long text formatted caption (HTML).

Steps to reproduce

Test a caption output where the original value contained html like <p> tags.

Proposed resolution

Consider the use of Xss::filterAdmin instead which allows paragraph tags but still provides protection in stripping styles and scripts. Apply only to processed values.

CommentFileSizeAuthor
Screenshot 2026-02-17 at 2.04.52 PM.png259.04 KBjoewhitsitt
Screenshot 2026-02-17 at 1.47.32 PM.png135.02 KBjoewhitsitt

Issue fork photoswipe-3574103

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joewhitsitt created an issue. See original summary.

joewhitsitt opened merge request !141

joewhitsitt’s picture

joewhitsitt
Location Iowa
commented
Status: Active » Needs review

Looks like an unrelated test failure

There was 1 failure:
1) Drupal\Tests\photoswipe\Kernel\AssetManagerTest::testPhotoswipeJsOptionsHook
Failed asserting that true matches expected false.