The Phone tests fail if the phone module is not enabled.

CommentFileSizeAuthor
#11 2636092-phone-tests-11.patch30.66 KBStevel
#7 2636092-phone-tests-7.patch29.51 KBStevel
#5 2636092-phone-tests-4.patch29.27 KBStevel
#3 2636092-phone-tests-3.patch14.83 KBStevel
#2 2636092-phone-tests.patch14.33 KBStevel

Comments

Stevel created an issue. See original summary.

Stevel’s picture

Stevel commented
Status: Active » Needs review
StatusFileSize
new 2636092-phone-tests.patch14.33 KB
Stevel’s picture

Stevel commented
StatusFileSize
new 2636092-phone-tests-3.patch14.83 KB

Error in the french test, adding the setUp method a second time.

Stevel’s picture

Stevel commented

Updated version of the patch to include only the test changes. Also removed translation strings from the getInfo() method and converted the tests to DrupalUnitTestCase to make the tests go faster

Stevel’s picture

Stevel commented
StatusFileSize
new 2636092-phone-tests-4.patch29.27 KB

And the patch...

Status: Needs review » Needs work

The last submitted patch, 5: 2636092-phone-tests-4.patch, failed testing.

Stevel’s picture

Stevel commented
Status: Needs work » Needs review
StatusFileSize
new 2636092-phone-tests-7.patch29.51 KB

Updated patch: Unit tests don't load modules, so explicitly include the needed phone.module file.

Status: Needs review » Needs work

The last submitted patch, 7: 2636092-phone-tests-7.patch, failed testing.

Stevel’s picture

Stevel commented
Title: Tests fail if phone module is not enabled » Tests fail to run if phone module is not enabled
Status: Needs work » Needs review
Parent issue: » #1108066: Fix phone Simpletest

This doesn't fix the tests yet, but at least it's possible to see the failing tests with this patch, which is the goal of this issue.

Stevel’s picture

Stevel commented
Stevel’s picture

Stevel commented
StatusFileSize
new 2636092-phone-tests-11.patch30.66 KB

This patch fixes some tests and disables the non-working tests by adding a dependency to a nonexistant module.