I've drafted a payment method controller for Plugnpay, a gateway commonly used in the Caribbean.

It works but there are some things I know need to be done better (like encrypt details that get temporarily stored in the context data), but mainly I'm wondering if I implemented the form correctly.

Right now the form that collects the payment details is implemented outside of the method controller. The sandbox project provides an example module that shows this implementation. This all works fine, payments get created correctly etc. But I have a nagging feeling that I was supposed to have implemented the plugnpay-specific form collection details within the method controller.

It would be awesome if you have time to cast an eye over the sandbox code and point me in the right direction. Thanks in advance, much.

https://www.drupal.org/sandbox/bartlett/2475399

Comments

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Version: 7.x-1.14 » 7.x-1.x-dev

I looked at this very quickly, but if I am correct you will want to configure the $payment_configuration_form_elements_callback property for your controller class. This allows any other module to embed the controller's form elements in their forms.

bart atlas’s picture

bart atlas commented

Xano, thanks much for checking it out and providing that feedback. I'll head down that path and look forward to any other input from the Payment gurus.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Active » Fixed

Thanks again for making this module! I won't have any time to review the entire module anytime soon, which is why I am closing this issue. If run into specific Payment-related problems, feel free to open new issues for them.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.